Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1585923007: Fix placeholder numbering in iOS specific strings. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix placeholder numbering in iOS specific strings. The string IDS_TRANSLATE_INFOBAR_NEVER_MESSAGE_IOS only used a single placeholder but used "$2" instead of "$1" causing a DCHECK. Use the correct value. Rename the constant IDS_IOS_TRANSLATE_INFOBAR_NEVER_MESSAGE and move the string to ios/chrome/app/ios_${branding}_strings.grd as it is only used on iOS. BUG=None Committed: https://crrev.com/395b039719c3594151d18bfd4231048353c1564b Cr-Commit-Position: refs/heads/master@{#369751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M components/translate_strings.grdp View 1 chunk +0 lines, -12 lines 0 comments Download
M ios/chrome/app/strings/ios_chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/ios_google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 11 months ago (2016-01-15 14:35:30 UTC) #2
droger
lgtm
4 years, 11 months ago (2016-01-15 15:33:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585923007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585923007/1
4 years, 11 months ago (2016-01-15 15:34:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 15:39:18 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 15:40:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/395b039719c3594151d18bfd4231048353c1564b
Cr-Commit-Position: refs/heads/master@{#369751}

Powered by Google App Engine
This is Rietveld 408576698