Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1585923004:
5X speed up of 'git cl format', which also speeds up 'git cl upload' (Closed)
|
Created:
4 years, 11 months ago by jkarlin Modified:
4 years, 11 months ago Reviewers:
agable CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
Description5X speed up of 'git cl format', which also speeds up 'git cl upload'
'git cl format' became very slow (7
seconds) after the Blink merge. 'git cl upload' is also slow when
the presubmit requires formatting checks.
This CL speeds up 'git cl format' by reducing the number of calls to
'git diff' and by removing the glob parameter. The glob
parameter adds a couple of seconds as it scans the entire
repository.
Before: 'git cl format' takes 7 seconds
After: 'git cl format' takes 1.25 seconds
BUG=577647
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298323
Patch Set 1 #Patch Set 2 : Nit #Patch Set 3 : Nit #Patch Set 4 : Update comment #Messages
Total messages: 16 (11 generated)
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged 'git cl format' became very slow (6.3 seconds). For directories with formatting presubmit checks this meant that a 'git cl upload' would also spend 6.3 seconds checking formatting. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 6.3 seconds After: 'git cl format' takes 1.3 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged 'git cl format' became very slow (6.3 seconds). For directories with formatting presubmit checks this meant that a 'git cl upload' would also spend 7 seconds checking formatting. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ==========
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged 'git cl format' became very slow (6.3 seconds). For directories with formatting presubmit checks this meant that a 'git cl upload' would also spend 7 seconds checking formatting. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged 'git cl format' became very slow (7 seconds). For directories with formatting presubmit checks this meant that a 'git cl upload' would also spend 7 seconds checking formatting per directory that checks it! This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ==========
jkarlin@chromium.org changed reviewers: + agable@chromium.org
agable@ PTAL, thanks!
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged 'git cl format' became very slow (7 seconds). For directories with formatting presubmit checks this meant that a 'git cl upload' would also spend 7 seconds checking formatting per directory that checks it! This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged 'git cl format' became very slow (7 seconds). This also slows 'git cl upload' in cases where the presubmit checks check formatting. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged 'git cl format' became very slow (7 seconds). This also slows 'git cl upload' in cases where the presubmit checks check formatting. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged, 'git cl format' became very slow (7 seconds). This also slows 'git cl upload' in cases where the presubmit checks check formatting. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ==========
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' Ever since Blink merged, 'git cl format' became very slow (7 seconds). This also slows 'git cl upload' in cases where the presubmit checks check formatting. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' 'git cl format' became very slow (7 seconds) after the Blink merge. 'git cl upload' is also slow when the presubmit requires formatting checks. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ==========
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' 'git cl format' became very slow (7 seconds) after the Blink merge. 'git cl upload' is also slow when the presubmit requires formatting checks. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter to git diff. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' 'git cl format' became very slow (7 seconds) after the Blink merge. 'git cl upload' is also slow when the presubmit requires formatting checks. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ==========
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' 'git cl format' became very slow (7 seconds) after the Blink merge. 'git cl upload' is also slow when the presubmit requires formatting checks. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' 'git cl format' became very slow (7 seconds) after the Blink merge. 'git cl upload' is also slow when the presubmit requires formatting checks. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ==========
Ping agable!
Ooh, I have no idea why I haven't seen this on my dashboard. LGTM!
The CQ bit was checked by jkarlin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585923004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585923004/80001
Message was sent while issue was closed.
Description was changed from ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' 'git cl format' became very slow (7 seconds) after the Blink merge. 'git cl upload' is also slow when the presubmit requires formatting checks. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 ========== to ========== 5X speed up of 'git cl format', which also speeds up 'git cl upload' 'git cl format' became very slow (7 seconds) after the Blink merge. 'git cl upload' is also slow when the presubmit requires formatting checks. This CL speeds up 'git cl format' by reducing the number of calls to 'git diff' and by removing the glob parameter. The glob parameter adds a couple of seconds as it scans the entire repository. Before: 'git cl format' takes 7 seconds After: 'git cl format' takes 1.25 seconds BUG=577647 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298323 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298323 |
