Issue 15859013: [chromedriver] Stop supporting chrome 26. Don't run tests against it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15859013: [chromedriver] Stop supporting chrome 26. Don't run tests against it. (Closed)

Created:
7 years, 6 months ago by kkania

Modified:
7 years, 6 months ago

Reviewers:
craigdh, frankf, chrisgao (Use stgao instead)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Stop supporting chrome 26. Don't run tests against it. BUG=none R=chrisgao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202912

Patch Set 2 : remove file upload check #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -26 lines)			Patch
M	chrome/test/chromedriver/archive.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/element_commands.cc	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/test/chromedriver/run_all_tests.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/chromedriver/run_py_tests.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/test/chromedriver/test_expectations	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chrisgao (Use stgao instead)

lgtm with a nit https://codereview.chromium.org/15859013/diff/1/chrome/test/chromedriver/chrome/version.cc File chrome/test/chromedriver/chrome/version.cc (right): https://codereview.chromium.org/15859013/diff/1/chrome/test/chromedriver/chrome/version.cc#newcode11 chrome/test/chromedriver/chrome/version.cc:11: const int kMinimumSupportedChromeVersion[] = {27, ...

7 years, 6 months ago (2013-05-29 16:14:52 UTC) #2

kkania

7 years, 6 months ago (2013-05-29 18:07:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r202912 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15859013: [chromedriver] Stop supporting chrome 26. Don't run tests against it. (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove file upload check #

Messages