Don't show post extension install bubbles when incognito mode is forced.

Don't show post extension install bubbles when incognito mode is forced.

This is a workaround to prevent a browser crash when non-incognito windows
are disabled.

BUG=38676, 244246
TBR=mnissler@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203916

[Joao da Silva, 2013-05-29 13:45:54]

Matt, we're introducing a CHECK when new windows that are disallowed by policy
are opened at https://codereview.chromium.org/15670011. This change is a
workaround to prevent such a crash when installing extensions in
forced-incognito mode (it doesn't affect unmanaged browsers).

It's not ideal, but if incognito is forced/disallowed then we should enforce
that, and any potential escape hatches are bugs.

Please have a look, thanks!

[Matt Perry, 2013-05-29 17:33:46]

lgtm

[commit-bot: I haz the power, 2013-05-30 00:12:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15859011/1

[commit-bot: I haz the power, 2013-05-30 00:37:49]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Joao da Silva, 2013-05-30 17:32:13]

@miket: please do an owner check for chrome/browser/ui/extensions. Thanks!

[miket_OOO, 2013-05-31 16:15:22]

lgtm

[commit-bot: I haz the power, 2013-05-31 18:49:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15859011/1

[commit-bot: I haz the power, 2013-05-31 19:17:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Joao da Silva, 2013-06-03 14:56:25]

Mattias, the incognito_mode_prefs.* changes from have been moved to this CL so
that the other one (https://codereview.chromium.org/15670011) can be landed
after this one. Inheriting the lgtm :-)

[commit-bot: I haz the power, 2013-06-03 14:56:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15859011/44001

[commit-bot: I haz the power, 2013-06-04 02:41:38]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-06-04 10:02:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15859011/44001

[commit-bot: I haz the power, 2013-06-04 10:49:49]

Change committed as 203916