Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 15859010: Add support for //# sourceURL similar to deprecated //@ sourceURL one. (Closed)

Created:
7 years, 6 months ago by vsevik
Modified:
7 years, 6 months ago
Reviewers:
yurys, Yang
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Add support for //# sourceURL similar to deprecated //@ sourceURL one. BUG=v8:2702 R=yangguo@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M include/v8.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/messages.js View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +21 lines, -8 lines 0 comments Download
M test/mjsunit/debug-compile-event.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-set-script-source.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-setbreakpoint.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1853.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsevik
7 years, 6 months ago (2013-05-29 12:01:58 UTC) #1
yurys
lgtm, +Yang for OWNERS approval
7 years, 6 months ago (2013-05-29 12:08:36 UTC) #2
Yang
On 2013/05/29 12:08:36, Yury Semikhatsky wrote: > lgtm, > +Yang for OWNERS approval LGTM.
7 years, 6 months ago (2013-05-29 12:15:32 UTC) #3
yurys
7 years, 6 months ago (2013-05-29 12:40:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698