Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: webkit/fileapi/file_system_context_unittest.cc

Issue 15859007: Move browser-specific FileAPI code from webkit/fileapi to webkit/browser/fileapi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dump_file_system build fix Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/fileapi/file_system_context.cc ('k') | webkit/fileapi/file_system_file_stream_reader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "webkit/fileapi/file_system_context.h"
6
7 #include "base/files/scoped_temp_dir.h"
8 #include "base/message_loop.h"
9 #include "base/stringprintf.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11 #include "webkit/browser/fileapi/external_mount_points.h"
12 #include "webkit/browser/fileapi/file_system_mount_point_provider.h"
13 #include "webkit/browser/fileapi/file_system_task_runners.h"
14 #include "webkit/browser/fileapi/isolated_context.h"
15 #include "webkit/browser/fileapi/mock_file_system_options.h"
16 #include "webkit/quota/mock_quota_manager.h"
17 #include "webkit/quota/mock_special_storage_policy.h"
18
19 #define FPL(x) FILE_PATH_LITERAL(x)
20
21 #if defined(FILE_PATH_USES_DRIVE_LETTERS)
22 #define DRIVE FPL("C:")
23 #else
24 #define DRIVE
25 #endif
26
27 namespace fileapi {
28
29 namespace {
30
31 const char kTestOrigin[] = "http://chromium.org/";
32 const base::FilePath::CharType kVirtualPathNoRoot[] = FPL("root/file");
33
34 GURL CreateRawFileSystemURL(const std::string& type_str,
35 const std::string& fs_id) {
36 std::string url_str = base::StringPrintf(
37 "filesystem:http://chromium.org/%s/%s/root/file",
38 type_str.c_str(),
39 fs_id.c_str());
40 return GURL(url_str);
41 }
42
43 class FileSystemContextTest : public testing::Test {
44 public:
45 FileSystemContextTest() {}
46
47 virtual void SetUp() {
48 ASSERT_TRUE(data_dir_.CreateUniqueTempDir());
49
50 storage_policy_ = new quota::MockSpecialStoragePolicy();
51
52 mock_quota_manager_ = new quota::MockQuotaManager(
53 false /* is_incognito */,
54 data_dir_.path(),
55 base::MessageLoopProxy::current(),
56 base::MessageLoopProxy::current(),
57 storage_policy_);
58 }
59
60 protected:
61 FileSystemContext* CreateFileSystemContextForTest(
62 ExternalMountPoints* external_mount_points) {
63 return new FileSystemContext(
64 FileSystemTaskRunners::CreateMockTaskRunners(),
65 external_mount_points,
66 storage_policy_,
67 mock_quota_manager_->proxy(),
68 ScopedVector<FileSystemMountPointProvider>(),
69 data_dir_.path(),
70 CreateAllowFileAccessOptions());
71 }
72
73 // Verifies a *valid* filesystem url has expected values.
74 void ExpectFileSystemURLMatches(const FileSystemURL& url,
75 const GURL& expect_origin,
76 FileSystemType expect_mount_type,
77 FileSystemType expect_type,
78 const base::FilePath& expect_path,
79 const base::FilePath& expect_virtual_path,
80 const std::string& expect_filesystem_id) {
81 EXPECT_TRUE(url.is_valid());
82
83 EXPECT_EQ(expect_origin, url.origin());
84 EXPECT_EQ(expect_mount_type, url.mount_type());
85 EXPECT_EQ(expect_type, url.type());
86 EXPECT_EQ(expect_path, url.path());
87 EXPECT_EQ(expect_virtual_path, url.virtual_path());
88 EXPECT_EQ(expect_filesystem_id, url.filesystem_id());
89 }
90
91 private:
92 base::ScopedTempDir data_dir_;
93 base::MessageLoop message_loop_;
94 scoped_refptr<quota::SpecialStoragePolicy> storage_policy_;
95 scoped_refptr<quota::MockQuotaManager> mock_quota_manager_;
96 };
97
98 // It is not valid to pass NULL ExternalMountPoints to FileSystemContext on
99 // ChromeOS.
100 #if !defined(OS_CHROMEOS)
101 TEST_F(FileSystemContextTest, NullExternalMountPoints) {
102 scoped_refptr<FileSystemContext> file_system_context(
103 CreateFileSystemContextForTest(NULL));
104
105 // Cracking system external mount and isolated mount points should work.
106 std::string isolated_name = "root";
107 std::string isolated_id =
108 IsolatedContext::GetInstance()->RegisterFileSystemForPath(
109 kFileSystemTypeNativeLocal,
110 base::FilePath(DRIVE FPL("/test/isolated/root")),
111 &isolated_name);
112 // Register system external mount point.
113 ASSERT_TRUE(ExternalMountPoints::GetSystemInstance()->RegisterFileSystem(
114 "system",
115 kFileSystemTypeNativeLocal,
116 base::FilePath(DRIVE FPL("/test/sys/"))));
117
118 FileSystemURL cracked_isolated = file_system_context->CrackURL(
119 CreateRawFileSystemURL("isolated", isolated_id));
120
121 ExpectFileSystemURLMatches(
122 cracked_isolated,
123 GURL(kTestOrigin),
124 kFileSystemTypeIsolated,
125 kFileSystemTypeNativeLocal,
126 base::FilePath(DRIVE FPL("/test/isolated/root/file")).NormalizePathSeparat ors(),
127 base::FilePath::FromUTF8Unsafe(isolated_id).Append(FPL("root/file")).
128 NormalizePathSeparators(),
129 isolated_id);
130
131 FileSystemURL cracked_external = file_system_context->CrackURL(
132 CreateRawFileSystemURL("external", "system"));
133
134 ExpectFileSystemURLMatches(
135 cracked_external,
136 GURL(kTestOrigin),
137 kFileSystemTypeExternal,
138 kFileSystemTypeNativeLocal,
139 base::FilePath(
140 DRIVE FPL("/test/sys/root/file")).NormalizePathSeparators(),
141 base::FilePath(FPL("system/root/file")).NormalizePathSeparators(),
142 "system");
143
144
145 IsolatedContext::GetInstance()->RevokeFileSystem(isolated_id);
146 ExternalMountPoints::GetSystemInstance()->RevokeFileSystem("system");
147 }
148 #endif // !defiend(OS_CHROMEOS)
149
150 TEST_F(FileSystemContextTest, FileSystemContextKeepsMountPointsAlive) {
151 scoped_refptr<ExternalMountPoints> mount_points =
152 ExternalMountPoints::CreateRefCounted();
153
154 // Register system external mount point.
155 ASSERT_TRUE(mount_points->RegisterFileSystem(
156 "system",
157 kFileSystemTypeNativeLocal,
158 base::FilePath(DRIVE FPL("/test/sys/"))));
159
160 scoped_refptr<FileSystemContext> file_system_context(
161 CreateFileSystemContextForTest(mount_points.get()));
162
163 // Release a MountPoints reference created in the test.
164 mount_points = NULL;
165
166 // FileSystemContext should keep a reference to the |mount_points|, so it
167 // should be able to resolve the URL.
168 FileSystemURL cracked_external = file_system_context->CrackURL(
169 CreateRawFileSystemURL("external", "system"));
170
171 ExpectFileSystemURLMatches(
172 cracked_external,
173 GURL(kTestOrigin),
174 kFileSystemTypeExternal,
175 kFileSystemTypeNativeLocal,
176 base::FilePath(
177 DRIVE FPL("/test/sys/root/file")).NormalizePathSeparators(),
178 base::FilePath(FPL("system/root/file")).NormalizePathSeparators(),
179 "system");
180
181 // No need to revoke the registered filesystem since |mount_points| lifetime
182 // is bound to this test.
183 }
184
185 TEST_F(FileSystemContextTest, CrackFileSystemURL) {
186 scoped_refptr<ExternalMountPoints> external_mount_points(
187 ExternalMountPoints::CreateRefCounted());
188 scoped_refptr<FileSystemContext> file_system_context(
189 CreateFileSystemContextForTest(external_mount_points));
190
191 // Register an isolated mount point.
192 std::string isolated_file_system_name = "root";
193 const std::string kIsolatedFileSystemID =
194 IsolatedContext::GetInstance()->RegisterFileSystemForPath(
195 kFileSystemTypeNativeLocal,
196 base::FilePath(DRIVE FPL("/test/isolated/root")),
197 &isolated_file_system_name);
198 // Register system external mount point.
199 ASSERT_TRUE(ExternalMountPoints::GetSystemInstance()->RegisterFileSystem(
200 "system",
201 kFileSystemTypeDrive,
202 base::FilePath(DRIVE FPL("/test/sys/"))));
203 ASSERT_TRUE(ExternalMountPoints::GetSystemInstance()->RegisterFileSystem(
204 "ext",
205 kFileSystemTypeNativeLocal,
206 base::FilePath(DRIVE FPL("/test/ext"))));
207 // Register a system external mount point with the same name/id as the
208 // registered isolated mount point.
209 ASSERT_TRUE(ExternalMountPoints::GetSystemInstance()->RegisterFileSystem(
210 kIsolatedFileSystemID,
211 kFileSystemTypeRestrictedNativeLocal,
212 base::FilePath(DRIVE FPL("/test/system/isolated"))));
213 // Add a mount points with the same name as a system mount point to
214 // FileSystemContext's external mount points.
215 ASSERT_TRUE(external_mount_points->RegisterFileSystem(
216 "ext",
217 kFileSystemTypeNativeLocal,
218 base::FilePath(DRIVE FPL("/test/local/ext/"))));
219
220 const GURL kTestOrigin = GURL("http://chromium.org/");
221 const base::FilePath kVirtualPathNoRoot = base::FilePath(FPL("root/file"));
222
223 struct TestCase {
224 // Test case values.
225 std::string root;
226 std::string type_str;
227
228 // Expected test results.
229 bool expect_is_valid;
230 FileSystemType expect_mount_type;
231 FileSystemType expect_type;
232 const base::FilePath::CharType* expect_path;
233 std::string expect_filesystem_id;
234 };
235
236 const TestCase kTestCases[] = {
237 // Following should not be handled by the url crackers:
238 {
239 "pers_mount", "persistent", true /* is_valid */,
240 kFileSystemTypePersistent, kFileSystemTypePersistent,
241 FPL("pers_mount/root/file"),
242 std::string() /* filesystem id */
243 },
244 {
245 "temp_mount", "temporary", true /* is_valid */,
246 kFileSystemTypeTemporary, kFileSystemTypeTemporary,
247 FPL("temp_mount/root/file"),
248 std::string() /* filesystem id */
249 },
250 // Should be cracked by isolated mount points:
251 {
252 kIsolatedFileSystemID, "isolated", true /* is_valid */,
253 kFileSystemTypeIsolated, kFileSystemTypeNativeLocal,
254 DRIVE FPL("/test/isolated/root/file"),
255 kIsolatedFileSystemID
256 },
257 // Should be cracked by system mount points:
258 {
259 "system", "external", true /* is_valid */,
260 kFileSystemTypeExternal, kFileSystemTypeDrive,
261 DRIVE FPL("/test/sys/root/file"),
262 "system"
263 },
264 {
265 kIsolatedFileSystemID, "external", true /* is_valid */,
266 kFileSystemTypeExternal, kFileSystemTypeRestrictedNativeLocal,
267 DRIVE FPL("/test/system/isolated/root/file"),
268 kIsolatedFileSystemID
269 },
270 // Should be cracked by FileSystemContext's ExternalMountPoints.
271 {
272 "ext", "external", true /* is_valid */,
273 kFileSystemTypeExternal, kFileSystemTypeNativeLocal,
274 DRIVE FPL("/test/local/ext/root/file"),
275 "ext"
276 },
277 // Test for invalid filesystem url (made invalid by adding invalid
278 // filesystem type).
279 {
280 "sytem", "external", false /* is_valid */,
281 // The rest of values will be ignored.
282 kFileSystemTypeUnknown, kFileSystemTypeUnknown, FPL(""),
283 std::string()
284 },
285 // Test for URL with non-existing filesystem id.
286 {
287 "invalid", "external", false /* is_valid */,
288 // The rest of values will be ignored.
289 kFileSystemTypeUnknown, kFileSystemTypeUnknown, FPL(""),
290 std::string()
291 },
292 };
293
294 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
295 const base::FilePath virtual_path =
296 base::FilePath::FromUTF8Unsafe(kTestCases[i].root).Append(kVirtualPathNo Root);
297
298 GURL raw_url =
299 CreateRawFileSystemURL(kTestCases[i].type_str, kTestCases[i].root);
300 FileSystemURL cracked_url = file_system_context->CrackURL(raw_url);
301
302 SCOPED_TRACE(testing::Message() << "Test case " << i << ": "
303 << "Cracking URL: " << raw_url);
304
305 EXPECT_EQ(kTestCases[i].expect_is_valid, cracked_url.is_valid());
306 if (!kTestCases[i].expect_is_valid)
307 continue;
308
309 ExpectFileSystemURLMatches(
310 cracked_url,
311 GURL(kTestOrigin),
312 kTestCases[i].expect_mount_type,
313 kTestCases[i].expect_type,
314 base::FilePath(kTestCases[i].expect_path).NormalizePathSeparators(),
315 virtual_path.NormalizePathSeparators(),
316 kTestCases[i].expect_filesystem_id);
317 }
318
319 IsolatedContext::GetInstance()->RevokeFileSystemByPath(
320 base::FilePath(DRIVE FPL("/test/isolated/root")));
321 ExternalMountPoints::GetSystemInstance()->RevokeFileSystem("system");
322 ExternalMountPoints::GetSystemInstance()->RevokeFileSystem("ext");
323 ExternalMountPoints::GetSystemInstance()->RevokeFileSystem(
324 kIsolatedFileSystemID);
325 }
326
327 } // namespace
328
329 } // namespace fileapi
OLDNEW
« no previous file with comments | « webkit/fileapi/file_system_context.cc ('k') | webkit/fileapi/file_system_file_stream_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698