SkValue: SkXfermode

src/effects/SkArithmeticMode.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkArithmeticMode.h"
 #include "SkColorPriv.h"
 #include "SkReadBuffer.h"
 #include "SkWriteBuffer.h"
 #include "SkString.h"
 #include "SkUnPreMultiply.h"
+#include "SkValueKeys.h"
 #if SK_SUPPORT_GPU
 #include "SkArithmeticMode_gpu.h"
 #endif
 
 static const bool gUseUnpremul = false;
 
 class SkArithmeticMode_scalar : public SkXfermode {
 public:
     static SkArithmeticMode_scalar* Create(SkScalar k1, SkScalar k2, SkScalar k3, SkScalar k4,
                                            bool enforcePMColor) {
         return new SkArithmeticMode_scalar(k1, k2, k3, k4, enforcePMColor);
     }
 
     virtual void xfer32(SkPMColor dst[], const SkPMColor src[], int count,
                         const SkAlpha aa[]) const override;
 
     SK_TO_STRING_OVERRIDE()
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkArithmeticMode_scalar)
 
 #if SK_SUPPORT_GPU
     bool asFragmentProcessor(const GrFragmentProcessor**,
                              const GrFragmentProcessor* dst) const override;
 
     bool asXPFactory(GrXPFactory**) const override;
 #endif
 
+    SkValue represent() const override {

[mtklein, 2016/01/14 22:58:28]

I don't yet see a need for key enums to be visible outside where it's
implemented.


enum { k0, k1, k2, k3, kEnforcePMColor };

SkValue represent() const override {
  auto value = SkValue::Object(SkValue::ArithmeticXfermode);
  value.set(k0, SkValue::fromF32(fK[0]);
  ...
  value.set(kEnforcePMColor, SkValue::FromS32(fEnforcePMColor));
  return value;
}

[hal.canary, 2016/01/14 23:43:10]

done.

+        auto value = SkValue::Object(SkValue::ArithmeticXfermode);
+        value.set(SkValueKeys::ArithmeticXfermode_K0, SkValue::FromF32(fK[0]));
+        value.set(SkValueKeys::ArithmeticXfermode_K1, SkValue::FromF32(fK[1]));
+        value.set(SkValueKeys::ArithmeticXfermode_K2, SkValue::FromF32(fK[2]));
+        value.set(SkValueKeys::ArithmeticXfermode_K3, SkValue::FromF32(fK[3]));
+        value.set(SkValueKeys::ArithmeticXfermode_EnforcePMColor,
+                  SkValue::FromS32(fEnforcePMColor ? 1 : 0));
+        return value;
+    }
+
 private:
     SkArithmeticMode_scalar(SkScalar k1, SkScalar k2, SkScalar k3, SkScalar k4, bool enforcePMColor) {
         fK[0] = k1;
         fK[1] = k2;
         fK[2] = k3;
         fK[3] = k4;
         fEnforcePMColor = enforcePMColor;
     }
 
     void flatten(SkWriteBuffer& buffer) const override {
@@ skipping 207 matching lines @@
                                              fEnforcePMColor);
     }
     return true;
 }
 
 #endif
 
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkArithmeticMode)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkArithmeticMode_scalar)
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END