SkValue: SkXfermode

src/core/SkValue.h

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkValue_DEFINED
 #define SkValue_DEFINED
 
 #include "SkTypes.h"
 #include <functional>
 
 class SkValue {
 public:
     enum Type : uint32_t {
         // 0-255 are reserved for built-in SkValue types.
         Null,
         Byte , S16 , U16 , S32 , U32 , S64 , U64 , F32 , F64 ,
         Bytes, S16s, U16s, S32s, U32s, S64s, U64s, F32s, F64s,
         Array,
 
         // 256-2147483647 may be used by Skia for public Object types.
 
+        ArithmeticXfermode = 0x100,
+        LerpXfermode,
+        OverdrawXfermode,
+        PixelXorXfermode,
+        ProcCoeffXfermode,
 
         // 2147483648+ won't be used by Skia.  They're open for client-specific use, testing, etc.
     };
 
-    enum Key : uint32_t {
+    typedef uint32_t Key;
         // Each Object type may define its own namespace of Key values,

[mtklein, 2016/01/14 22:58:28]

Move this left and over the typedef, and update to something like

// Each Object type may define its own namespace of Key values.
// Their namespace is distinct from other uint32_ts, like Type.

?

[hal.canary, 2016/01/14 23:43:10]

done

         // so there are no pre-defined Keys here.
         //
         // This is just a reminder that they must fit in a uint32_t,
         // and that their namespace is distinct from other uint32_ts (e.g. Type).
-    };
-
     SkValue();
     SkValue(const SkValue&);
     SkValue(SkValue&&);
 
     SkValue& operator=(const SkValue&);
     SkValue& operator=(SkValue&&);
 
     ~SkValue();
 
     static SkValue FromS32(int32_t);
@@ skipping 25 matching lines @@
     union {
         int32_t       fS32;
         uint32_t      fU32;
         float         fF32;
         class Bytes*  fBytes;
         class Object* fObject;
     };
 };
 
 #endif//SkValue_DEFINED