src/core/SkValueKeys.h - Issue 1585813004: SkValue: SkXfermode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/core/SkValueKeys.h

Issue 1585813004: SkValue: SkXfermode (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: comments from mtklein Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2016 Google Inc.

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #ifndef SkValueKeys_DEFINED

	9 #define SkValueKeys_DEFINED

	10

	11 #include "SkValue.h"
	mtklein 2016/01/21 19:01:23 Not really needed? Not really needed? hal.canary 2016/01/21 19:33:40 done Show quoted text On 2016/01/21 at 19:01:23, mtklein wrote: > Not really needed? done
	12

	13 namespace SkValueKeys {

	14 namespace ArithmeticXfermode { enum { kK0, kK1, kK2, kK3, kEnforcePMColor }; }
	mtklein 2016/01/21 19:01:23 Might want to indent these inner namespaces a bit? Might want to indent these inner namespaces a bit? hal.canary 2016/01/21 19:33:40 done Show quoted text On 2016/01/21 at 19:01:23, mtklein wrote: > Might want to indent these inner namespaces a bit? done
	15 namespace LerpXfermode { enum { kScale }; }

	16 namespace PixelXorXfermode { enum { kOpColor }; }

	17 namespace ProcCoeffXfermode { enum { kMode }; }

	18 }

	19

	20 #endif // SkValueKeys_DEFINED

OLD	NEW