SkValue: SkXfermode

src/effects/SkArithmeticMode.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkArithmeticMode.h"
 #include "SkColorPriv.h"
 #include "SkReadBuffer.h"
 #include "SkWriteBuffer.h"
 #include "SkString.h"
 #include "SkUnPreMultiply.h"
+#include "SkValueKeys.h"
 #if SK_SUPPORT_GPU
 #include "SkArithmeticMode_gpu.h"
 #endif
 
 static const bool gUseUnpremul = false;
 
 class SkArithmeticMode_scalar : public SkXfermode {
 public:
     static SkXfermode* Create(SkScalar k1, SkScalar k2, SkScalar k3, SkScalar k4,
                               bool enforcePMColor) {
@@ skipping 22 matching lines @@
         fEnforcePMColor = enforcePMColor;
     }
 
     void flatten(SkWriteBuffer& buffer) const override {
         buffer.writeScalar(fK[0]);
         buffer.writeScalar(fK[1]);
         buffer.writeScalar(fK[2]);
         buffer.writeScalar(fK[3]);
         buffer.writeBool(fEnforcePMColor);
     }
+
+    SkValue asValue() const override {

[mtklein, 2016/01/21 17:46:18]

Boy that's super verbose.

These seem like a good place for a very localized using:
    using namespace SkValueKeys::ArithmeticXfermode;
    auto value = SkValue::Object(SkValue::ArithmeticXfermode);
    value.set(kK0, SkValue::FromF32(fK[0]));
    ...

[hal.canary, 2016/01/21 18:35:21]

done.

+        auto value = SkValue::Object(SkValue::ArithmeticXfermode);
+        value.set(SkValueKeys::ArithmeticXfermode::kK0,
+                  SkValue::FromF32(fK[0]));
+        value.set(SkValueKeys::ArithmeticXfermode::kK1,
+                  SkValue::FromF32(fK[1]));
+        value.set(SkValueKeys::ArithmeticXfermode::kK2,
+                  SkValue::FromF32(fK[2]));
+        value.set(SkValueKeys::ArithmeticXfermode::kK3,
+                  SkValue::FromF32(fK[3]));
+        value.set(SkValueKeys::ArithmeticXfermode::kEnforcePMColor,
+                  SkValue::FromS32(fEnforcePMColor ? 1 : 0));
+        return value;
+    }
+
     SkScalar fK[4];
     bool fEnforcePMColor;
 
     friend class SkArithmeticMode;
 
     typedef SkXfermode INHERITED;
 };
 
 SkFlattenable* SkArithmeticMode_scalar::CreateProc(SkReadBuffer& buffer) {
     const SkScalar k1 = buffer.readScalar();
@@ skipping 191 matching lines @@
                                              fEnforcePMColor);
     }
     return true;
 }
 
 #endif
 
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkArithmeticMode)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkArithmeticMode_scalar)
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END