SkValue: SkXfermode

src/utils/debugger/SkDebugCanvas.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkClipStack.h"
 #include "SkColorPriv.h"
 #include "SkDebugCanvas.h"
 #include "SkDrawCommand.h"
 #include "SkDevice.h"
 #include "SkPaintFilterCanvas.h"
 #include "SkXfermode.h"
+#include "SkValue.h"
 
 namespace {
 
 class OverdrawXfermode : public SkXfermode {
 public:
     SkPMColor xferColor(SkPMColor src, SkPMColor dst) const override {
         // This table encodes the color progression of the overdraw visualization
         static const SkPMColor gTable[] = {
             SkPackARGB32(0x00, 0x00, 0x00, 0x00),
             SkPackARGB32(0xFF, 128, 158, 255),
@@ skipping 22 matching lines @@
         ++idx;
         SkASSERT(idx < (int)SK_ARRAY_COUNT(gTable));
 
         return gTable[idx];
     }
 
     Factory getFactory() const override { return nullptr; }
 #ifndef SK_IGNORE_TO_STRING
     void toString(SkString* str) const override { str->set("OverdrawXfermode"); }
 #endif
+    // We don't serialize this xfermode.
+    SkValue asValue() const override { return SkValue(); }

[mtklein, 2016/01/15 17:26:20]

Let's make this the default impl on SkXfermode, at least for now?  That makes
working with values opt-in rather than opt-out as we've got now.

[hal.canary, 2016/01/15 19:44:31]

done.  I'll do this with all of the SkFooPaintEffect classes.

 };
 
 class DebugPaintFilterCanvas : public SkPaintFilterCanvas {
 public:
     DebugPaintFilterCanvas(int width,
                            int height,
                            bool overdrawViz,
                            bool overrideFilterQuality,
                            SkFilterQuality quality)
         : INHERITED(width, height)
@@ skipping 594 matching lines @@
 }
 
 bool SkDebugCanvas::lastClipStackData(const SkPath& devPath) {
     if (fCalledAddStackData) {
         fClipStackData.appendf("<br>");
         addPathData(devPath, "pathOut");
         return true;
     }
     return false;
 }