Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1585813002: S390: Makefile + Build Toolchain Updates (Closed)

Created:
4 years, 11 months ago by JoranSiu
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Makefile + Build Toolchain Updates This is the first of several commits to contribute Linux on z Systems (s390/s390x) port of V8. We will be breaking up the changes into several (hopefully) logical commits. This commit contains the changes to V8 Makefile and build toolchains to introduce S390 macros and compiler options. Just for awareness for reviewers is that s390 is 31-bit (not 32!) big-endian platform on Linux on z. (MSB of address is used to distinguish between 24-bit vs 31-bit addressing!) s390x is 64-bit Linux on z. Names follow the general linux convention on the platform. A quick roadmap on upcoming commits: - Add \#include of S390 header files in common files - S390 related tests + tooling changes - printf macro for printing size_t values. - S390 platform-specific code generation code (bulk of changes!) R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com BUG= Committed: https://crrev.com/1091c2f07e8a02e20a14cd28b283297b7bce13bb Cr-Commit-Position: refs/heads/master@{#33304}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed s390 files from v8.gyp #

Patch Set 3 : Add S390 target defines to BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -11 lines) Patch
M BUILD.gn View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +2 lines, -1 line 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain.gypi View 6 chunks +41 lines, -8 lines 0 comments Download
M src/base/build_config.h View 4 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 24 (9 generated)
JoranSiu
This is the first of several commits to contribute our Linux on z Systems (S390) ...
4 years, 11 months ago (2016-01-13 22:11:56 UTC) #3
john.yan
lgtm
4 years, 11 months ago (2016-01-13 23:39:16 UTC) #5
michael_dawson
On 2016/01/13 23:39:16, john.yan wrote: > lgtm lgtm
4 years, 11 months ago (2016-01-13 23:42:20 UTC) #6
michael_dawson
On 2016/01/13 23:39:16, john.yan wrote: > lgtm lgtm
4 years, 11 months ago (2016-01-13 23:42:23 UTC) #7
michael_dawson
On 2016/01/13 23:39:16, john.yan wrote: > lgtm lgtm
4 years, 11 months ago (2016-01-13 23:42:28 UTC) #8
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp#newcode1425 tools/gyp/v8.gyp:1425: '../../src/compiler/s390/code-generator-s390.cc', please don't add files here yet without them ...
4 years, 11 months ago (2016-01-14 14:04:40 UTC) #9
JoranSiu
On 2016/01/14 14:04:40, jochen wrote: > https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp > File tools/gyp/v8.gyp (right): > > https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp#newcode1425 > ...
4 years, 11 months ago (2016-01-14 14:48:20 UTC) #10
jochen (gone - plz use gerrit)
forgot to add, could you also modify the BUILD.gn file?
4 years, 11 months ago (2016-01-14 14:49:08 UTC) #11
JoranSiu
On 2016/01/14 14:49:08, jochen wrote: > forgot to add, could you also modify the BUILD.gn ...
4 years, 11 months ago (2016-01-14 15:46:33 UTC) #12
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-14 16:26:21 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585813002/40001
4 years, 11 months ago (2016-01-14 16:35:26 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 16:57:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585813002/40001
4 years, 11 months ago (2016-01-14 17:12:12 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 17:16:15 UTC) #22
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:17:19 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1091c2f07e8a02e20a14cd28b283297b7bce13bb
Cr-Commit-Position: refs/heads/master@{#33304}

Powered by Google App Engine
This is Rietveld 408576698