S390: Makefile + Build Toolchain Updates

S390: Makefile + Build Toolchain Updates

This is the first of several commits to contribute Linux on z Systems
(s390/s390x) port of V8.  We will be breaking up the changes into several
(hopefully) logical commits.

This commit contains the changes to V8 Makefile and build toolchains to
introduce S390 macros and compiler options.  Just for awareness for reviewers
is that s390 is 31-bit (not 32!) big-endian platform on Linux on z.  (MSB of address
is used to distinguish between 24-bit vs 31-bit addressing!)  s390x is
64-bit Linux on z.  Names follow the general linux convention on the platform.

A quick roadmap on upcoming commits:
- Add \#include of S390 header files in common files
- S390 related tests + tooling changes
- printf macro for printing size_t values.
- S390 platform-specific code generation code (bulk of changes!)

R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com
BUG=

Committed: https://crrev.com/1091c2f07e8a02e20a14cd28b283297b7bce13bb
Cr-Commit-Position: refs/heads/master@{#33304}

[JoranSiu, 2016-01-13 22:10:30]

Description was changed from

==========
S390: Makefile + Build Toolchain Updates

This is the first of several commits to contribute Linux on z Systems
(s390/s390x) port of V8.  We will be breaking up the changes into several
(hopefully) logical commits.

This commit contains the changes to V8 Makefile and build toolchains to
introduce S390 macros and compiler options.  Just for awareness for reviewers
is that s390 is 31-bit (not 32!) platform on Linux on z.  (MSB of address
is used to distinguish between 24-bit vs 31-bit addressing!)  s390x is
64-bit Linux on z.  Names follow the general linux convention on the platform.

A quick roadmap on upcoming commits:
- Add \#include of S390 header files in common files
- S390 related tests + tooling changes
- printf macro for printing size_t values.
- S390 platform-specific code generation code (bulk of changes!)

R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca...
BUG=
==========

to

==========
S390: Makefile + Build Toolchain Updates

This is the first of several commits to contribute Linux on z Systems
(s390/s390x) port of V8.  We will be breaking up the changes into several
(hopefully) logical commits.

This commit contains the changes to V8 Makefile and build toolchains to
introduce S390 macros and compiler options.  Just for awareness for reviewers
is that s390 is 31-bit (not 32!) big-endian platform on Linux on z.  (MSB of
address
is used to distinguish between 24-bit vs 31-bit addressing!)  s390x is
64-bit Linux on z.  Names follow the general linux convention on the platform.

A quick roadmap on upcoming commits:
- Add \#include of S390 header files in common files
- S390 related tests + tooling changes
- printf macro for printing size_t values.
- S390 platform-specific code generation code (bulk of changes!)

R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca...
BUG=
==========

[JoranSiu, 2016-01-13 22:10:30]

joransiu@ca.ibm.com changed reviewers:
+ mbrandy@us.ibm.com
- mtbrandyberry@ca.ibm.com

[JoranSiu, 2016-01-13 22:11:56]

This is the first of several commits to contribute our Linux on z Systems (S390)
port of V8.

[danno, 2016-01-13 22:17:19]

danno@chromium.org changed reviewers:
+ jochen@chromium.org
- svenpanne@chromium.org

[john.yan, 2016-01-13 23:39:16]

lgtm

[michael_dawson, 2016-01-13 23:42:20]

On 2016/01/13 23:39:16, john.yan wrote:
> lgtm

lgtm

[michael_dawson, 2016-01-13 23:42:23]

On 2016/01/13 23:39:16, john.yan wrote:
> lgtm

lgtm

[michael_dawson, 2016-01-13 23:42:28]

On 2016/01/13 23:39:16, john.yan wrote:
> lgtm

lgtm

[jochen (gone - plz use gerrit), 2016-01-14 14:04:40]

https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp#newcode1425
tools/gyp/v8.gyp:1425: '../../src/compiler/s390/code-generator-s390.cc',
please don't add files here yet without them being in the repository

[JoranSiu, 2016-01-14 14:48:20]

On 2016/01/14 14:04:40, jochen wrote:
> https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp
> File tools/gyp/v8.gyp (right):
> 
> https://codereview.chromium.org/1585813002/diff/1/tools/gyp/v8.gyp#newcode1425
> tools/gyp/v8.gyp:1425: '../../src/compiler/s390/code-generator-s390.cc',
> please don't add files here yet without them being in the repository

Thanks @jochen.  I've revert the v8.gyp changes, and will commit them along with
the files.

[jochen (gone - plz use gerrit), 2016-01-14 14:49:08]

forgot to add, could you also modify the BUILD.gn file?

[JoranSiu, 2016-01-14 15:46:33]

On 2016/01/14 14:49:08, jochen wrote:
> forgot to add, could you also modify the BUILD.gn file?

Added S390 target defines to BUILD.gn in Patch Set 3.  As per v8.gyp, I'll
update 'sources' in this file once the s390 files are in the repository.

[jochen (gone - plz use gerrit), 2016-01-14 16:26:21]

lgtm

[JoranSiu, 2016-01-14 16:35:19]

The CQ bit was checked by joransiu@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 16:35:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585813002/40001

[commit-bot: I haz the power, 2016-01-14 16:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 16:57:41]

Dry run: This issue passed the CQ dry run.

[JoranSiu, 2016-01-14 17:12:00]

The CQ bit was checked by joransiu@ca.ibm.com

[JoranSiu, 2016-01-14 17:12:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
michael_dawson@ca.ibm.com, jyan@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/1585813002/#ps40001
(title: "Add S390 target defines to BUILD.gn")

[commit-bot: I haz the power, 2016-01-14 17:12:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585813002/40001

[commit-bot: I haz the power, 2016-01-14 17:16:14]

Description was changed from

==========
S390: Makefile + Build Toolchain Updates

This is the first of several commits to contribute Linux on z Systems
(s390/s390x) port of V8.  We will be breaking up the changes into several
(hopefully) logical commits.

This commit contains the changes to V8 Makefile and build toolchains to
introduce S390 macros and compiler options.  Just for awareness for reviewers
is that s390 is 31-bit (not 32!) big-endian platform on Linux on z.  (MSB of
address
is used to distinguish between 24-bit vs 31-bit addressing!)  s390x is
64-bit Linux on z.  Names follow the general linux convention on the platform.

A quick roadmap on upcoming commits:
- Add \#include of S390 header files in common files
- S390 related tests + tooling changes
- printf macro for printing size_t values.
- S390 platform-specific code generation code (bulk of changes!)

R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca...
BUG=
==========

to

==========
S390: Makefile + Build Toolchain Updates

This is the first of several commits to contribute Linux on z Systems
(s390/s390x) port of V8.  We will be breaking up the changes into several
(hopefully) logical commits.

This commit contains the changes to V8 Makefile and build toolchains to
introduce S390 macros and compiler options.  Just for awareness for reviewers
is that s390 is 31-bit (not 32!) big-endian platform on Linux on z.  (MSB of
address
is used to distinguish between 24-bit vs 31-bit addressing!)  s390x is
64-bit Linux on z.  Names follow the general linux convention on the platform.

A quick roadmap on upcoming commits:
- Add \#include of S390 header files in common files
- S390 related tests + tooling changes
- printf macro for printing size_t values.
- S390 platform-specific code generation code (bulk of changes!)

R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca...
BUG=
==========

[commit-bot: I haz the power, 2016-01-14 17:16:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-14 17:17:18]

Description was changed from

==========
S390: Makefile + Build Toolchain Updates

This is the first of several commits to contribute Linux on z Systems
(s390/s390x) port of V8.  We will be breaking up the changes into several
(hopefully) logical commits.

This commit contains the changes to V8 Makefile and build toolchains to
introduce S390 macros and compiler options.  Just for awareness for reviewers
is that s390 is 31-bit (not 32!) big-endian platform on Linux on z.  (MSB of
address
is used to distinguish between 24-bit vs 31-bit addressing!)  s390x is
64-bit Linux on z.  Names follow the general linux convention on the platform.

A quick roadmap on upcoming commits:
- Add \#include of S390 header files in common files
- S390 related tests + tooling changes
- printf macro for printing size_t values.
- S390 platform-specific code generation code (bulk of changes!)

R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca...
BUG=
==========

to

==========
S390: Makefile + Build Toolchain Updates

This is the first of several commits to contribute Linux on z Systems
(s390/s390x) port of V8.  We will be breaking up the changes into several
(hopefully) logical commits.

This commit contains the changes to V8 Makefile and build toolchains to
introduce S390 macros and compiler options.  Just for awareness for reviewers
is that s390 is 31-bit (not 32!) big-endian platform on Linux on z.  (MSB of
address
is used to distinguish between 24-bit vs 31-bit addressing!)  s390x is
64-bit Linux on z.  Names follow the general linux convention on the platform.

A quick roadmap on upcoming commits:
- Add \#include of S390 header files in common files
- S390 related tests + tooling changes
- printf macro for printing size_t values.
- S390 platform-specific code generation code (bulk of changes!)

R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca...
BUG=

Committed: https://crrev.com/1091c2f07e8a02e20a14cd28b283297b7bce13bb
Cr-Commit-Position: refs/heads/master@{#33304}
==========

[commit-bot: I haz the power, 2016-01-14 17:17:19]

Patchset 3 (id:??) landed as
https://crrev.com/1091c2f07e8a02e20a14cd28b283297b7bce13bb
Cr-Commit-Position: refs/heads/master@{#33304}