Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1585753002: Verify that import prefixes don't shadow exports. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
A + tests/language/export_not_shadowed_by_prefix_helper.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A + tests/language/export_not_shadowed_by_prefix_helper2.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + tests/language/export_not_shadowed_by_prefix_test.dart View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-13 19:17:40 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-13 19:41:57 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-13 20:45:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51f8e5f82a27b420e09881e4bfb509d3b8af8791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698