Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 1585733002: Marks spawn_shutdown_test Pass, Slow for debug builds. (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Marks spawn_shutdown_test Pass, Slow for debug builds. The test is timing out on the Debug windows bot, but always finishes for me locally even under load. If it continues to timeout even when marked Slow, I will investigate more locally. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/ebbd05a8b2525f16abb10e5c228138ce609021a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 11 months ago (2016-01-13 18:24:07 UTC) #2
siva
lgtm
4 years, 11 months ago (2016-01-13 18:34:42 UTC) #3
zra
4 years, 11 months ago (2016-01-13 18:38:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ebbd05a8b2525f16abb10e5c228138ce609021a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698