Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1585693002: Move trace_event.h include from v8_platform.h to .cc file (Closed)

Created:
4 years, 11 months ago by Tomasz Moniuszko
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move trace_event.h include from v8_platform.h to .cc file trace_event.h is redundant in header file. It also causes compilation issues when Blink precompiled headers are used on Windows (Bug 495697). BUG= Committed: https://crrev.com/3641693cdb43bb82b681668228dacb978310e217 Cr-Commit-Position: refs/heads/master@{#371801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gin/public/v8_platform.h View 1 chunk +0 lines, -1 line 0 comments Download
M gin/v8_platform.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Tomasz Moniuszko
4 years, 11 months ago (2016-01-13 14:44:06 UTC) #2
Tomasz Moniuszko
ping :) +jochen@chromium.org as reviewer
4 years, 11 months ago (2016-01-27 14:11:48 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-27 14:13:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585693002/1
4 years, 11 months ago (2016-01-27 14:15:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 16:28:54 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 16:29:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3641693cdb43bb82b681668228dacb978310e217
Cr-Commit-Position: refs/heads/master@{#371801}

Powered by Google App Engine
This is Rietveld 408576698