Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: Source/core/html/HTMLAllCollection.idl

Issue 158563004: Make HTMLAllCollection named property getter behave more according to spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase and get rid of code duplication Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLAllCollection.cpp ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLAllCollection.idl
diff --git a/Source/core/html/HTMLAllCollection.idl b/Source/core/html/HTMLAllCollection.idl
index f7103af16fc429173c6b2bedcaa0af7e7c0e6fb5..5ca9c6b3c3b09357e9047816381e4d8ee24c8295 100644
--- a/Source/core/html/HTMLAllCollection.idl
+++ b/Source/core/html/HTMLAllCollection.idl
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 2014 Samsung Electronics. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -23,6 +24,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// FIXME: This interface should inherit HTMLCollection.
[
Custom=LegacyCallAsFunction,
DependentLifetime,
@@ -31,6 +33,6 @@
readonly attribute unsigned long length;
[ImplementedAs=item] getter Element (unsigned long index);
[Custom] Element item([Default=Undefined] optional unsigned long index);
- [NotEnumerable] getter (NodeList or Element) (DOMString name);
- [Custom] Element namedItem(DOMString name);
+ // FIXME: This should return an (HTMLCollection or Element) union.
+ [ImplementedAs=namedGetter] getter (NodeList or Element) namedItem(DOMString name);
};
« no previous file with comments | « Source/core/html/HTMLAllCollection.cpp ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698