Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: Source/core/html/HTMLAllCollection.cpp

Issue 158563004: Make HTMLAllCollection named property getter behave more according to spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase and get rid of code duplication Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLAllCollection.h ('k') | Source/core/html/HTMLAllCollection.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 } 57 }
58 58
59 if (Vector<Element*>* cache = nameCache(name)) { 59 if (Vector<Element*>* cache = nameCache(name)) {
60 if (index < cache->size()) 60 if (index < cache->size())
61 return cache->at(index); 61 return cache->at(index);
62 } 62 }
63 63
64 return 0; 64 return 0;
65 } 65 }
66 66
67 void HTMLAllCollection::anonymousNamedGetter(const AtomicString& name, bool& ret urnValue0Enabled, RefPtr<NodeList>& returnValue0, bool& returnValue1Enabled, Ref Ptr<Element>& returnValue1) 67 void HTMLAllCollection::namedGetter(const AtomicString& name, bool& returnValue0 Enabled, RefPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtr<Eleme nt>& returnValue1)
68 { 68 {
69 Vector<RefPtr<Element> > namedItems; 69 Vector<RefPtr<Element> > namedItems;
70 this->namedItems(name, namedItems); 70 this->namedItems(name, namedItems);
71 71
72 if (!namedItems.size()) 72 if (!namedItems.size())
73 return; 73 return;
74 74
75 if (namedItems.size() == 1) { 75 if (namedItems.size() == 1) {
76 returnValue1Enabled = true; 76 returnValue1Enabled = true;
77 returnValue1 = namedItems.at(0); 77 returnValue1 = namedItems.at(0);
78 return; 78 return;
79 } 79 }
80 80
81 // FIXME: HTML5 specification says this should be a HTMLCollection. 81 // FIXME: HTML5 specification says this should be a HTMLCollection.
82 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection 82 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection
83 returnValue0Enabled = true; 83 returnValue0Enabled = true;
84 returnValue0 = NamedNodesCollection::create(namedItems); 84 returnValue0 = NamedNodesCollection::create(namedItems);
85 } 85 }
86 86
87 } // namespace WebCore 87 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAllCollection.h ('k') | Source/core/html/HTMLAllCollection.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698