Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 158563002: [PPAPI] pp::Var uses the latest version of the PPB_Var API. (Closed)

Created:
6 years, 10 months ago by Matt Giuca
Modified:
6 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org, yzshen1, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

[PPAPI] pp::Var uses the latest version of the PPB_Var API. It previously used version 1.0 even if version 1.1 was available. BUG=342250 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250314

Patch Set 1 #

Patch Set 2 : VarFromUtf8Helper make comment future-proof. #

Patch Set 3 : AddRefHelper and ReleaseHelper methods simplify logic in the methods. #

Total comments: 2

Patch Set 4 : Remove final else when all if/elseif branches return. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
M ppapi/cpp/var.cc View 1 2 3 6 chunks +42 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Matt Giuca
Precursor to https://codereview.chromium.org/148213016/ (which adds version 1.2 to Var).
6 years, 10 months ago (2014-02-10 00:25:31 UTC) #1
Matt Giuca
I've refactored it a bit. I think this way makes it easier to add new ...
6 years, 10 months ago (2014-02-10 00:48:33 UTC) #2
dmichael (off chromium)
lgtm https://codereview.chromium.org/158563002/diff/60001/ppapi/cpp/var.cc File ppapi/cpp/var.cc (right): https://codereview.chromium.org/158563002/diff/60001/ppapi/cpp/var.cc#newcode67 ppapi/cpp/var.cc:67: } per the style guide (as mentioned in ...
6 years, 10 months ago (2014-02-10 22:53:08 UTC) #3
Matt Giuca
https://codereview.chromium.org/158563002/diff/60001/ppapi/cpp/var.cc File ppapi/cpp/var.cc (right): https://codereview.chromium.org/158563002/diff/60001/ppapi/cpp/var.cc#newcode67 ppapi/cpp/var.cc:67: } On 2014/02/10 22:53:08, dmichael wrote: > per the ...
6 years, 10 months ago (2014-02-10 23:58:09 UTC) #4
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 10 months ago (2014-02-11 00:01:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/158563002/110001
6 years, 10 months ago (2014-02-11 00:07:46 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 03:45:45 UTC) #7
Message was sent while issue was closed.
Change committed as 250314

Powered by Google App Engine
This is Rietveld 408576698