Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1585623003: Support SVG fragment URLs in cross faded images (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support SVG fragment URLs in cross faded images Extract url from CSSImageValue and pass it along to the SVGImage wrapper. Constify CSSImageValue::url() in the process. Also, fix typo and indentation in related test. BUG=574172 Committed: https://crrev.com/ece900bafe8d6ff3346ed364a5d3fd13799b8620 Cr-Commit-Position: refs/heads/master@{#369156}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
davve
The promised follow-up on fragments for cross-fades SVG images.
4 years, 11 months ago (2016-01-13 11:38:32 UTC) #2
fs
lgtm
4 years, 11 months ago (2016-01-13 11:57:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585623003/1
4 years, 11 months ago (2016-01-13 12:27:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 13:55:49 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 13:56:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ece900bafe8d6ff3346ed364a5d3fd13799b8620
Cr-Commit-Position: refs/heads/master@{#369156}

Powered by Google App Engine
This is Rietveld 408576698