Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1585573002:
Attempt to isolate ui_android_unittests_apk. (Closed)
|
Created:
4 years, 11 months ago by ghost stip (do not use) Modified:
4 years, 11 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAttempt to isolate ui_android_unittests_apk.
BUG=525873
R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org
TBR=miguelg@chromium.org
Committed: https://crrev.com/c292fb7b2ab240d3a5bc3d90633627c9377a1568
Cr-Commit-Position: refs/heads/master@{#369378}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (6 generated)
I ran this locally. The isolate dir was deleted so I don't know if the logcats were written, but at least it didn't crash. https://codereview.chromium.org/1585573002/diff/1/ui/android/ui_android_unitt... File ui/android/ui_android_unittests_apk.isolate (left): https://codereview.chromium.org/1585573002/diff/1/ui/android/ui_android_unitt... ui/android/ui_android_unittests_apk.isolate:10: '<(PRODUCT_DIR)/bin/run_ui_android_unittests', '-v', the -v should have been removed a while ago
lgtm
lgtm
miguelg: OWNERS stamp :)
Description was changed from ========== Attempt to isolate ui_android_unittests_apk. BUG=525873 R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org ========== to ========== Attempt to isolate ui_android_unittests_apk. BUG=525873 R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org TBR=miguelg@chromium.org ==========
tbring as this shouldn't affect anything production, please revert if bad!
The CQ bit was checked by stip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585573002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by stip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585573002/1
Message was sent while issue was closed.
Description was changed from ========== Attempt to isolate ui_android_unittests_apk. BUG=525873 R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org TBR=miguelg@chromium.org ========== to ========== Attempt to isolate ui_android_unittests_apk. BUG=525873 R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org TBR=miguelg@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Attempt to isolate ui_android_unittests_apk. BUG=525873 R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org TBR=miguelg@chromium.org ========== to ========== Attempt to isolate ui_android_unittests_apk. BUG=525873 R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org TBR=miguelg@chromium.org Committed: https://crrev.com/c292fb7b2ab240d3a5bc3d90633627c9377a1568 Cr-Commit-Position: refs/heads/master@{#369378} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c292fb7b2ab240d3a5bc3d90633627c9377a1568 Cr-Commit-Position: refs/heads/master@{#369378} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
