Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Side by Side Diff: fpdfsdk/src/fpdfview_embeddertest.cpp

Issue 1585533002: Fix infinite loops caused by calling circular indirect objects (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments and rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 #include <string> 6 #include <string>
7 7
8 #include "fpdfsdk/src/fpdfview_c_api_test.h" 8 #include "fpdfsdk/src/fpdfview_c_api_test.h"
9 #include "public/fpdfview.h" 9 #include "public/fpdfview.h"
10 #include "testing/embedder_test.h" 10 #include "testing/embedder_test.h"
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 TEST_F(FPDFViewEmbeddertest, Hang_343) { 228 TEST_F(FPDFViewEmbeddertest, Hang_343) {
229 EXPECT_FALSE(OpenDocument("bug_343.pdf")); 229 EXPECT_FALSE(OpenDocument("bug_343.pdf"));
230 } 230 }
231 231
232 // The test should pass when the absence of 'Contents' field in a signature 232 // The test should pass when the absence of 'Contents' field in a signature
233 // dictionary will not cause an infinite loop in CPDF_SyntaxParser::GetObject(). 233 // dictionary will not cause an infinite loop in CPDF_SyntaxParser::GetObject().
234 TEST_F(FPDFViewEmbeddertest, Hang_344) { 234 TEST_F(FPDFViewEmbeddertest, Hang_344) {
235 EXPECT_FALSE(OpenDocument("bug_344.pdf")); 235 EXPECT_FALSE(OpenDocument("bug_344.pdf"));
236 } 236 }
237 237
238 // The test should pass when there is no infinite recursion in
239 // CPDF_SyntaxParser::GetString().
240 TEST_F(FPDFViewEmbeddertest, Hang_355) {
241 EXPECT_FALSE(OpenDocument("bug_355.pdf"));
242 }
238 // The test should pass even when the file has circular references to pages. 243 // The test should pass even when the file has circular references to pages.
239 TEST_F(FPDFViewEmbeddertest, Hang_360) { 244 TEST_F(FPDFViewEmbeddertest, Hang_360) {
240 EXPECT_FALSE(OpenDocument("bug_360.pdf")); 245 EXPECT_FALSE(OpenDocument("bug_360.pdf"));
241 } 246 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698