Array access fix: g++ darwin 4.2.1 compiler clamped array index to 0 when confronted with negative …

Array access fix: g++ darwin 4.2.1 compiler clamped array index to 0 when confronted with negative indices.

BUG=247303
R=jkummerow@chromium.org, ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15038

[mvstanton, 2013-06-10 14:41:31]

Hi guys, here is the arguments.h fix, from the bug seen in Android compiles.

[ulan, 2013-06-10 14:42:38]

lgtm

[Jakob Kummerow, 2013-06-10 14:43:38]

LGTM with nit.

https://codereview.chromium.org/15855015/diff/1/src/arguments.h
File src/arguments.h (right):

https://codereview.chromium.org/15855015/diff/1/src/arguments.h#newcode55
src/arguments.h:55: return
*(reinterpret_cast<Object**>(reinterpret_cast<intptr_t>(arguments_) -
The minus at the end of the line looks weird. I'd prefer to format as:

    return *(reinterpret_cast<Object**>(
        reinterpret_cast<intptr_t>(arguments_) - index * kPointerSize));

[mvstanton, 2013-06-10 14:44:10]

Committed patchset #1 manually as r15038 (presubmit successful).