Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7241)

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 15855010: Make ExtensionMsg_MessageInvoke run a module system function rather than a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test compile Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/extension_helper.h ('k') | chrome/renderer/extensions/miscellaneous_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/extension_helper.cc
diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc
index a5e7ef48347afc013c0d161442927ac040bf6f32..0f2eca4df86873dce92ec049a587d96058a02d5f 100644
--- a/chrome/renderer/extensions/extension_helper.cc
+++ b/chrome/renderer/extensions/extension_helper.cc
@@ -250,16 +250,13 @@ void ExtensionHelper::OnExtensionResponse(int request_id,
}
void ExtensionHelper::OnExtensionMessageInvoke(const std::string& extension_id,
+ const std::string& module_name,
const std::string& function_name,
const base::ListValue& args,
bool user_gesture) {
- scoped_ptr<WebScopedUserGesture> web_user_gesture;
- if (user_gesture) {
- web_user_gesture.reset(new WebScopedUserGesture);
- }
-
- dispatcher_->v8_context_set().DispatchChromeHiddenMethod(
- extension_id, function_name, args, render_view());
+ dispatcher_->InvokeModuleSystemMethod(
+ render_view(), extension_id, module_name, function_name, args,
+ user_gesture);
}
void ExtensionHelper::OnExtensionDispatchOnConnect(
@@ -364,7 +361,8 @@ void ExtensionHelper::OnAppWindowClosed() {
dispatcher_->v8_context_set().GetByV8Context(script_context);
if (!chrome_v8_context)
return;
- chrome_v8_context->CallChromeHiddenMethod("OnAppWindowClosed", 0, NULL, NULL);
+ chrome_v8_context->module_system()->CallModuleMethod(
+ "app.window", "onAppWindowClosed");
}
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/extension_helper.h ('k') | chrome/renderer/extensions/miscellaneous_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698