Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6340)

Unified Diff: chrome/renderer/extensions/event_unittest.cc

Issue 15855010: Make ExtensionMsg_MessageInvoke run a module system function rather than a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test compile Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/dispatcher.cc ('k') | chrome/renderer/extensions/extension_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/event_unittest.cc
diff --git a/chrome/renderer/extensions/event_unittest.cc b/chrome/renderer/extensions/event_unittest.cc
index ff6aedbb34f77d9f26aff57f0d877545f8b65a0a..92c225e8e1882fc904205cf7d9458947f1e07642 100644
--- a/chrome/renderer/extensions/event_unittest.cc
+++ b/chrome/renderer/extensions/event_unittest.cc
@@ -18,6 +18,7 @@ class EventUnittest : public ModuleSystemTest {
RegisterModule("schemaUtils", IDR_SCHEMA_UTILS_JS);
RegisterModule("utils", IDR_UTILS_JS);
RegisterModule("json_schema", IDR_JSON_SCHEMA_JS);
+ RegisterModule("unload_event", IDR_UNLOAD_EVENT_JS);
// Mock out the native handler for event_bindings. These mocks will fail if
// any invariants maintained by the real event_bindings are broken.
@@ -113,7 +114,7 @@ TEST_F(EventUnittest, OnUnloadDetachesAllListeners) {
"var cb2 = function() {};"
"myEvent.addListener(cb1);"
"myEvent.addListener(cb2);"
- "chromeHidden.dispatchOnUnload();"
+ "require('unload_event').dispatch();"
"assert.AssertFalse(!!eventBindings.attachedListeners['named-event']);");
module_system_->Require("test");
}
@@ -130,7 +131,7 @@ TEST_F(EventUnittest, OnUnloadDetachesAllListenersEvenDupes) {
"var cb1 = function() {};"
"myEvent.addListener(cb1);"
"myEvent.addListener(cb1);"
- "chromeHidden.dispatchOnUnload();"
+ "require('unload_event').dispatch();"
"assert.AssertFalse(!!eventBindings.attachedListeners['named-event']);");
module_system_->Require("test");
}
@@ -155,14 +156,14 @@ TEST_F(EventUnittest, EventsThatSupportRulesMustHaveAName) {
TEST_F(EventUnittest, NamedEventDispatch) {
ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
RegisterModule("test",
- "require('event');"
+ "var event = require('event');"
"var Event = requireNative('chrome').GetChrome().Event;"
"var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();"
"var assert = requireNative('assert');"
"var e = new Event('myevent');"
"var called = false;"
"e.addListener(function() { called = true; });"
- "chromeHidden.Event.dispatchEvent('myevent', []);"
+ "event.dispatchEvent('myevent', []);"
"assert.AssertTrue(called);");
module_system_->Require("test");
}
« no previous file with comments | « chrome/renderer/extensions/dispatcher.cc ('k') | chrome/renderer/extensions/extension_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698