Make ExtensionMsg_MessageInvoke run a module system function rather than a

chrome/renderer/extensions/chrome_v8_context_set.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_EXTENSIONS_CHROME_V8_CONTEXT_SET_H_
 #define CHROME_RENDERER_EXTENSIONS_CHROME_V8_CONTEXT_SET_H_
 
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/bind.h"
 #include "v8/include/v8.h"
 
 class GURL;
 
 namespace base {
 class ListValue;
 }
 
 namespace content {
 class RenderView;
@@ skipping 30 matching lines @@
 
   // Gets the ChromeV8Context corresponding to the v8::Context that is
   // on the top of the stack, or NULL if no such context exists.
   ChromeV8Context* GetCurrent() const;
 
   // Gets the ChromeV8Context corresponding to the specified
   // v8::Context or NULL if no such context exists.
   ChromeV8Context* GetByV8Context(
       v8::Handle<v8::Context> context) const;
 
-  // Calls chromeHidden.<methodName> in each context for <extension_id>. If
-  // render_view is non-NULL, only call the function in contexts belonging to
-  // that view. The called javascript function should not return a value other
-  // than v8::Undefined(). A DCHECK is setup to break if it is otherwise.
-  void DispatchChromeHiddenMethod(const std::string& extension_id,
-                                  const std::string& method_name,
-                                  const base::ListValue& arguments,
-                                  content::RenderView* render_view) const;
+  // Re-entrantly runs |callback| with each ChromeV8Context that belongs to

[koz (OOO until 15th September), 2013/05/31 04:28:44]

The word "re-entrantly" makes me think that the callback is being called back
into while it is being called, but in reality it's just getting invoked one time
on each ChromeV8Context. Could you rephrase?

[not at google - send to devlin, 2013/05/31 22:47:07]

Done.

+  // |extension_id| in |render_view|.
+  //
+  // |extension_id| may be "" to match all extensions.
+  // |render_view| may be NULL to match all render views.
+  void ForEach(const std::string& extension_id,
+               content::RenderView* render_view,
+               const base::Callback<void(ChromeV8Context*)>& callback) const;
 
   // Cleans up contexts belonging to an unloaded extension.
   //
   // Returns the set of ChromeV8Contexts that were removed as a result. These
   // are safe to interact with until the end of the current event loop, since
   // they're deleted asynchronously.
   ContextSet OnExtensionUnloaded(const std::string& extension_id);
 
  private:
   ContextSet contexts_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeV8ContextSet);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_RENDERER_EXTENSIONS_CHROME_V8_CONTEXT_SET_H_