cc: Call ManageTiles explicitly

cc: Call ManageTiles explicitly

ManageTiles used to be scheduled as a post task to run "whenever".  This was
fine back when activation checks used the exact state of the tree.  However,
now that activation has been moved to tile manager, ManageTiles is now
responsible for keeping the activation check up to date and needs
to be called immediately after commit to makes sure that new work has been
marked as required.

Before this patch, ManageTiles would generally run after commits and after
drawing due to the nature of scheduling.  This patch keeps that behavior by
doing a ManageTiles after a commit and after drawing.

R=reveman@chromium.org
BUG=243531
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204923

[enne (OOO), 2013-05-30 22:51:43]

This depends on https://codereview.chromium.org/16190002/.

[reveman, 2013-06-04 22:17:51]

This looks great!

Is the change to manage_tiles_needed in RegisterTile/UnregisterTile needed?
Doesn't LTHI already know when we need to call ManagedTiles as a result of tiles
being added or removed? I'm asking as I feel like the manage_tiles_needed state
belongs in LTHI where we control the calls to TileManager::ManageTiles() and
would prefer to see it moved there if possible.

[enne (OOO), 2013-06-04 22:40:19]

On 2013/06/04 22:17:51, David Reveman wrote:
> This looks great!
> 
> Is the change to manage_tiles_needed in RegisterTile/UnregisterTile needed?
> Doesn't LTHI already know when we need to call ManagedTiles as a result of
tiles
> being added or removed? I'm asking as I feel like the manage_tiles_needed
state
> belongs in LTHI where we control the calls to TileManager::ManageTiles() and
> would prefer to see it moved there if possible.

It's not required.  The call to WillModifyTilePriorities in PictureLayerImpl
should take care of it.  Moved the manage_tiles_needed_ to LTHI.  PTAL.

[reveman, 2013-06-05 13:23:40]

lgtm, nice!

[commit-bot: I haz the power, 2013-06-06 18:30:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/15855008/8001

[commit-bot: I haz the power, 2013-06-07 09:28:08]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-06-07 13:46:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/15855008/8001

[commit-bot: I haz the power, 2013-06-07 13:46:08]

Failed to apply patch for cc/resources/tile_manager.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/resources/tile_manager.h
  Hunk #1 succeeded at 37 (offset 11 lines).
  Hunk #2 succeeded at 101 (offset 11 lines).
  Hunk #3 FAILED at 125.
  Hunk #4 succeeded at 197 (offset 18 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
cc/resources/tile_manager.h.rej

Patch:       cc/resources/tile_manager.h
Index: cc/resources/tile_manager.h
diff --git a/cc/resources/tile_manager.h b/cc/resources/tile_manager.h
index
057ae92ec15f443fa4e432b637a3ae4b2c2def9d..21ab6a76078e47d2f62974662b515c89bf84ce1f
100644
--- a/cc/resources/tile_manager.h
+++ b/cc/resources/tile_manager.h
@@ -26,7 +26,6 @@ class TileVersion;
 
 class CC_EXPORT TileManagerClient {
  public:
-  virtual void ScheduleManageTiles() = 0;
   virtual void DidInitializeVisibleTile() = 0;
   virtual bool
       ShouldForceTileUploadsRequiredForActivationToComplete() const = 0;
@@ -91,10 +90,6 @@ class CC_EXPORT TileManager {
     return memory_stats_from_last_assign_;
   }
 
-  void WillModifyTilePriorities() {
-    ScheduleManageTiles();
-  }
-
   bool AreTilesRequiredForActivationReady() const {
     return tiles_that_need_to_be_initialized_for_activation_.empty();
   }
@@ -130,12 +125,6 @@ class CC_EXPORT TileManager {
   void SortTiles();
   void AssignGpuMemoryToTiles();
   void FreeResourcesForTile(Tile* tile);
-  void ScheduleManageTiles() {
-    if (manage_tiles_pending_)
-      return;
-    client_->ScheduleManageTiles();
-    manage_tiles_pending_ = true;
-  }
   RasterWorkerPool::Task CreateImageDecodeTask(
       Tile* tile, skia::LazyPixelRef* pixel_ref);
   void OnImageDecodeTaskCompleted(
@@ -184,8 +173,6 @@ class CC_EXPORT TileManager {
   TileManagerClient* client_;
   scoped_ptr<ResourcePool> resource_pool_;
   scoped_ptr<RasterWorkerPool> raster_worker_pool_;
-  bool manage_tiles_pending_;
-
   GlobalStateThatImpactsTilePriority global_state_;
 
   typedef std::vector<Tile*> TileVector;

[commit-bot: I haz the power, 2013-06-07 17:08:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/15855008/36001

[commit-bot: I haz the power, 2013-06-07 20:58:28]

Change committed as 204923