Issue 15855004: Fixed a typo in DesktopSessionProxy::SetScreenResolution().

Issue 15855004: Fixed a typo in DesktopSessionProxy::SetScreenResolution(). (Closed)

Created:
7 years, 6 months ago by alexeypa (please no reviews)

Modified:
7 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed a typo in DesktopSessionProxy::SetScreenResolution(). The typo was causing DesktopSessionProxy to ignore a valid screen resolution. I also added a unit test to excercise SetScreenResolution(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203313

Patch Set 1 #

Total comments: 2

Patch Set 2 : - #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	remoting/host/desktop_session_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	remoting/host/ipc_desktop_environment_unittest.cc	View	1	6 chunks	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm https://codereview.chromium.org/15855004/diff/1/remoting/host/ipc_desktop_environment_unittest.cc File remoting/host/ipc_desktop_environment_unittest.cc (right): https://codereview.chromium.org/15855004/diff/1/remoting/host/ipc_desktop_environment_unittest.cc#newcode630 remoting/host/ipc_desktop_environment_unittest.cc:630: // Tests injection of mouse events. Update the ...

7 years, 6 months ago (2013-05-30 19:01:54 UTC) #2

alexeypa (please no reviews)

https://codereview.chromium.org/15855004/diff/1/remoting/host/ipc_desktop_environment_unittest.cc File remoting/host/ipc_desktop_environment_unittest.cc (right): https://codereview.chromium.org/15855004/diff/1/remoting/host/ipc_desktop_environment_unittest.cc#newcode630 remoting/host/ipc_desktop_environment_unittest.cc:630: // Tests injection of mouse events. On 2013/05/30 19:01:55, ...

7 years, 6 months ago (2013-05-30 19:21:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/15855004/9001

7 years, 6 months ago (2013-05-30 19:22:19 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=155982

7 years, 6 months ago (2013-05-31 00:04:23 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/15855004/9001

7 years, 6 months ago (2013-05-31 01:22:17 UTC) #6

Message was sent while issue was closed.

Change committed as 203313

Expand Messages | Collapse Messages