[parser] reject parenthesized patterns as DestructuringAssignmentTargets

[parser] reject parenthesized patterns as DestructuringAssignmentTargets

http://tc39.github.io/ecma262/#sec-destructuring-assignment-static-semantics-early-errors
requires that DestructuringAssignmentTargets which do not match Pattern productions,
must return true for IsValidSimpleAssignmentTarget.

This change rejects parenthesized patterns with a SyntaxError.

BUG=v8:4662, v8:811
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, nikolaos@chromium.org

Committed: https://crrev.com/6b28f294c1217fbf12e4d60e5969b439efc6f839
Cr-Commit-Position: refs/heads/master@{#33254}

[caitp (gmail), 2016-01-12 23:13:21]

PTAL

[caitp (gmail), 2016-01-12 23:15:16]

https://codereview.chromium.org/1585473002/diff/1/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1585473002/diff/1/src/parsing/parser-base.h#n...
src/parsing/parser-base.h:3292: classifier->RecordBindingPatternError(location,
message);
technically, this bit isn't needed because of an UnexpectedToken error --- but
we could replace the unexpected token error with this, which might be a bit
nicer

[adamk, 2016-01-12 23:17:11]

https://codereview.chromium.org/1585473002/diff/1/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1585473002/diff/1/src/parsing/parser-base.h#n...
src/parsing/parser-base.h:3292: classifier->RecordBindingPatternError(location,
message);
On 2016/01/12 23:15:16, caitp wrote:
> technically, this bit isn't needed because of an UnexpectedToken error --- but
> we could replace the unexpected token error with this, which might be a bit
> nicer

I'd rather leave this out of the change if we were already reporting an error
here, leaving this change only as a correctness fix.

If you'd like to do a followup patch with a message test, that'd be fine.

[caitp (gmail), 2016-01-12 23:31:18]

https://codereview.chromium.org/1585473002/diff/1/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1585473002/diff/1/src/parsing/parser-base.h#n...
src/parsing/parser-base.h:3292: classifier->RecordBindingPatternError(location,
message);
On 2016/01/12 23:17:11, adamk wrote:
> On 2016/01/12 23:15:16, caitp wrote:
> > technically, this bit isn't needed because of an UnexpectedToken error ---
but
> > we could replace the unexpected token error with this, which might be a bit
> > nicer
> 
> I'd rather leave this out of the change if we were already reporting an error
> here, leaving this change only as a correctness fix.
> 
> If you'd like to do a followup patch with a message test, that'd be fine.

Alright, done, anything else?

[adamk, 2016-01-12 23:32:23]

lgtm

[adamk, 2016-01-12 23:34:54]

(and thanks for the super-quick fix!)

[caitp (gmail), 2016-01-13 00:13:54]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2016-01-13 00:13:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585473002/20001

[commit-bot: I haz the power, 2016-01-13 00:40:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-13 00:41:25]

Description was changed from

==========
[parser] reject parenthesized patterns as DestructuringAssignmentTargets

http://tc39.github.io/ecma262/#sec-destructuring-assignment-static-semantics-...
requires that DestructuringAssignmentTargets which do not match Pattern
productions,
must return true for IsValidSimpleAssignmentTarget.

This change rejects parenthesized patterns with a SyntaxError.

BUG=v8:4662, v8:811
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, nikolaos@chromium.org
==========

to

==========
[parser] reject parenthesized patterns as DestructuringAssignmentTargets

http://tc39.github.io/ecma262/#sec-destructuring-assignment-static-semantics-...
requires that DestructuringAssignmentTargets which do not match Pattern
productions,
must return true for IsValidSimpleAssignmentTarget.

This change rejects parenthesized patterns with a SyntaxError.

BUG=v8:4662, v8:811
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, nikolaos@chromium.org

Committed: https://crrev.com/6b28f294c1217fbf12e4d60e5969b439efc6f839
Cr-Commit-Position: refs/heads/master@{#33254}
==========

[commit-bot: I haz the power, 2016-01-13 00:41:26]

Patchset 2 (id:??) landed as
https://crrev.com/6b28f294c1217fbf12e4d60e5969b439efc6f839
Cr-Commit-Position: refs/heads/master@{#33254}