Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1585433002: Fix SourcePosition_IfElse test (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix SourcePosition_IfElse test Some column positions were off by 2. Committed: https://github.com/dart-lang/sdk/commit/e51dc673ba5f1252596930baf854ab69af484f93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/vm/flow_graph_builder_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
TBR
4 years, 11 months ago (2016-01-12 21:17:24 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as e51dc673ba5f1252596930baf854ab69af484f93 (presubmit successful).
4 years, 11 months ago (2016-01-12 21:17:37 UTC) #5
rmacnak
4 years, 11 months ago (2016-01-12 21:36:08 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698