Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2126)

Unified Diff: tests/corelib/uri_query_test.dart

Issue 15854003: Fix some bugs in the Uri class (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/core/uri.dart ('K') | « sdk/lib/core/uri.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/uri_query_test.dart
diff --git a/tests/corelib/uri_query_test.dart b/tests/corelib/uri_query_test.dart
index acbe9d8b2b49cbd2b38ea716ef2abfbdca9d2fda..d26c1db10dcbbcf5704a7e8ded25b48d33f49247 100644
--- a/tests/corelib/uri_query_test.dart
+++ b/tests/corelib/uri_query_test.dart
@@ -19,13 +19,14 @@ void testEncodeQueryComponent() {
}
void testQueryParameters() {
- test(String query, Map<String, String> parameters) {
+ test(String query, Map<String, String> parameters, [String normalizedQuery]) {
+ if (normalizedQuery === null) normalizedQuery = query;
check(uri) {
- Expect.equals(query, uri.query);
+ Expect.equals(normalizedQuery, uri.query);
if (query.isEmpty) {
- Expect.equals(query, uri.toString());
+ Expect.equals(normalizedQuery, uri.toString());
} else {
- Expect.equals("?$query", uri.toString());
+ Expect.equals("?$normalizedQuery", uri.toString());
}
if (parameters.containsValue(null)) {
} else {
@@ -45,18 +46,28 @@ void testQueryParameters() {
test("", {});
test("A", {"A": null});
+ test("%25", {"%": null});
+ test("%41", {"A": null}, "A");
+ test("%41A", {"AA": null}, "AA");
test("A", {"A": ""});
+ test("%25", {"%": ""});
+ test("%41", {"A": ""}, "A");
+ test("%41A", {"AA": ""}, "AA");
test("A=a", {"A": "a"});
+ test("%25=a", {"%": "a"});
+ test("%41=%61", {"A": "a"}, "A=a");
test("A=+", {"A": " "});
test("A=%2B", {"A": "+"});
test("A=a&B", {"A": "a", "B": null});
test("A=a&B", {"A": "a", "B": ""});
test("A=a&B=b", {"A": "a", "B": "b"});
+ test("%41=%61&%42=%62", {"A": "a", "B": "b"}, "A=a&B=b");
var unreserved = "-._~0123456789"
"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
"abcdefghijklmnopqrstuvwxyz";
var encoded = new StringBuffer();
+ var allEncoded = new StringBuffer();
var unencoded = new StringBuffer();
for (int i = 32; i < 128; i++) {
if (i == 32) {
@@ -67,18 +78,29 @@ void testQueryParameters() {
encoded.write("%");
encoded.write(i.toRadixString(16).toUpperCase());
}
+ if (i == 32) {
+ allEncoded.write("+");
+ } else {
+ allEncoded.write("%");
+ allEncoded.write(i.toRadixString(16).toUpperCase());
+ }
unencoded.writeCharCode(i);
}
encoded = encoded.toString();
unencoded = unencoded.toString();
- print(encoded);
- print(unencoded);
test("a=$encoded", {"a": unencoded});
test("a=$encoded&b=$encoded", {"a": unencoded, "b": unencoded});
var map = new Map();
map[unencoded] = unencoded;
test("$encoded=$encoded", map);
+ test("$encoded=$allEncoded", map, "$encoded=$encoded");
+ test("$allEncoded=$encoded", map, "$encoded=$encoded");
+ test("$allEncoded=$allEncoded", map, "$encoded=$encoded");
+ map[unencoded] = null;
+ test("$encoded", map);
+ map[unencoded] = "";
+ test("$encoded", map);
}
testInvalidQueryParameters() {
« sdk/lib/core/uri.dart ('K') | « sdk/lib/core/uri.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698