third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp - Issue 1585383003: Add deprecation message for -webkit-background-composite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

Issue 1585383003: Add deprecation message for -webkit-background-composite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/StyleSheetContents.cpp ('k') | third_party/WebKit/Source/core/frame/DeprecationHelper.h » ('j') | third_party/WebKit/Source/core/frame/DeprecationHelper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

index 93be952e3cdc4455f546b926a4ba3ca096cb73ed..ba01f55b9f34180bd4a0c292485a4e52680a013f 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

@@ -24,6 +24,7 @@

#include "core/css/parser/MediaQueryParser.h"

#include "core/dom/Document.h"

#include "core/dom/Element.h"

+#include "core/frame/DeprecationHelper.h"

#include "core/frame/UseCounter.h"

#include "platform/TraceEvent.h"

#include "wtf/BitArray.h"

@@ -692,6 +693,8 @@ void CSSParserImpl::consumeDeclaration(CSSParserTokenRange range, StyleRule::Typ

ASSERT(range.peek().type() == IdentToken);

const CSSParserToken& token = range.consumeIncludingWhitespace();

CSSPropertyID unresolvedProperty = token.parseAsUnresolvedCSSPropertyID();

+ if (m_styleSheet && m_styleSheet->singleOwnerDocument())

+ DeprecationHelper::showDeprecationWarning(m_styleSheet->singleOwnerDocument()->frame(), unresolvedProperty);

if (range.consume().type() != ColonToken)

return; // Parse error