Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1585383003: Add deprecation message for -webkit-background-composite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index d0bd56bd08244de9d7622c72f894eac7f03dfa6d..6004f00131bf14163611c97a262bcb6caff41d08 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -742,11 +742,14 @@ void UseCounter::countCrossOriginIframe(const Document& document, Feature featur
count(frame, feature);
}
+// TODO(nainar): Migrate all console message functions to Deprecation
nainar 2016/02/01 07:48:41 removed space between TODO and (nainar)
static const char* milestoneString(int milestone)
{
switch (milestone) {
case 50:
return "M50, around April 2016";
+ case 51:
+ return "M51, around June 2016";
case 53:
return "M53, around September 2016";
}
@@ -760,7 +763,7 @@ static String replacedBy(const char* feature, const char* replacement)
return String::format("%s is deprecated. Please use %s instead.", feature, replacement);
}
-static String willBeRemoved(const char* feature, int milestone, const char* details)
+String UseCounter::willBeRemoved(const char* feature, int milestone, const char* details)
{
return String::format("%s is deprecated and will be removed in %s. See https://www.chromestatus.com/features/%s for more details.", feature, milestoneString(milestone), details);
}

Powered by Google App Engine
This is Rietveld 408576698