Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

Issue 1585383003: Add deprecation message for -webkit-background-composite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
index 93be952e3cdc4455f546b926a4ba3ca096cb73ed..5fdfa387e254ec0207536ff458c1bec77be7f7a1 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
@@ -24,6 +24,7 @@
#include "core/css/parser/MediaQueryParser.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
+#include "core/frame/Deprecation.h"
#include "core/frame/UseCounter.h"
#include "platform/TraceEvent.h"
#include "wtf/BitArray.h"
@@ -692,6 +693,8 @@ void CSSParserImpl::consumeDeclaration(CSSParserTokenRange range, StyleRule::Typ
ASSERT(range.peek().type() == IdentToken);
const CSSParserToken& token = range.consumeIncludingWhitespace();
CSSPropertyID unresolvedProperty = token.parseAsUnresolvedCSSPropertyID();
+ if (m_styleSheet && m_styleSheet->singleOwnerDocument() && unresolvedProperty != CSSPropertyInvalid)
Timothy Loh 2016/01/25 04:48:41 Probably better to put this at the bottom of the f
nainar 2016/01/25 05:33:22 Done
+ Deprecation::showConsoleWarning(m_styleSheet->singleOwnerDocument()->frame(), unresolvedProperty);
Timothy Loh 2016/01/25 04:48:41 I don't like the naming, this sounds like we're sh
nainar 2016/01/25 05:33:21 Done
if (range.consume().type() != ColonToken)
return; // Parse error

Powered by Google App Engine
This is Rietveld 408576698