fuzz: signalBug() / signalBoring()

fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log verbosely.

signalBug() now triggers SIGSEGV rather than SIGABRT.  This should make it work with catchsegv more easily.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1585353002

Committed: https://skia.googlesource.com/skia/+/a115942ed69762206f87c680ef7ec98de3382fa6

[mtklein_C, 2016-01-14 21:21:00]

Description was changed from

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

BUG=skia:
==========

to

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-01-14 21:25:32]

Description was changed from

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

Seems like verbose logging should be the default.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-01-14 21:41:34]

Description was changed from

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

Seems like verbose logging should be the default.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log.
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-14 21:50:34]

Description was changed from

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log.
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log verbosely.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-14 21:51:14]

mtklein@chromium.org changed reviewers:
+ kjlubick@google.com

[mtklein_C, 2016-01-14 21:51:15]

A little bit of a counter-proposal to your latest CL.

[mtklein_C, 2016-01-15 13:17:38]

Description was changed from

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log verbosely.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log verbosely.

signalBug() now triggers SIGSEGV rather than SIGABRT.  This should make it work
with catchsegv more easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[kjlubick, 2016-01-15 13:21:31]

lgtm

This seems a bit cleaner.

[mtklein, 2016-01-15 13:22:07]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-01-15 13:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585353002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585353002/100001

[kjlubick, 2016-01-15 13:22:23]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-01-15 13:22:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585353002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585353002/100001

[commit-bot: I haz the power, 2016-01-15 13:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 13:23:01]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[mtklein, 2016-01-15 13:24:39]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-01-15 13:24:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kjlubick@google.com
Link to the patchset: https://codereview.chromium.org/1585353002/#ps120001
(title: "stdlib for abs()")

[commit-bot: I haz the power, 2016-01-15 13:24:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585353002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585353002/120001

[commit-bot: I haz the power, 2016-01-15 13:46:57]

Description was changed from

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log verbosely.

signalBug() now triggers SIGSEGV rather than SIGABRT.  This should make it work
with catchsegv more easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fuzz: signalBug() / signalBoring()

Instead of a single ASSERT macro, this switches to two new methods:
   - signalBug():    tell afl-fuzz there's a bug caused by its inputs (by
crashing)
   - signalBoring(): tell afl-fuzz these inputs are not worth testing (by
exiting gracefully)

I'm not seeing any effect on fuzz/s when I just always log verbosely.

signalBug() now triggers SIGSEGV rather than SIGABRT.  This should make it work
with catchsegv more easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a115942ed69762206f87c680ef7ec98de3382fa6
==========

[commit-bot: I haz the power, 2016-01-15 13:46:58]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/a115942ed69762206f87c680ef7ec98de3382fa6