Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1585323007: Re-enable FeatureUtilities test related to Google Accounts (Closed)

Created:
4 years, 11 months ago by nyquist
Modified:
4 years, 11 months ago
Reviewers:
mdjones
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable FeatureUtilities test related to Google Accounts The tests were disabled a long time ago, so there are no available logs to see the flakes, and no apparent reason as to why it was flaky. There has been cleanup/refactoring around this area, so this might have fixed itself. Temporarily re-enabling the tests to either keep then re-enabled or to get a helpful log. The TODO will be removed later if this ends up working well. BUG=543160 Committed: https://crrev.com/e88912d4be5f46564412daff14dcf125dbcf37a8 Cr-Commit-Position: refs/heads/master@{#369923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/util/FeatureUtilitiesTest.java View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nyquist
mdjones: PTAL
4 years, 11 months ago (2016-01-16 01:32:59 UTC) #2
mdjones
lgtm
4 years, 11 months ago (2016-01-16 01:34:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585323007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585323007/1
4 years, 11 months ago (2016-01-16 01:35:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-16 02:08:55 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 02:09:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e88912d4be5f46564412daff14dcf125dbcf37a8
Cr-Commit-Position: refs/heads/master@{#369923}

Powered by Google App Engine
This is Rietveld 408576698