Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1585323003: fix #25486, promote from dynamic in strong mode (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -19 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +10 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 3 chunks +21 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +45 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 11 months ago (2016-01-14 23:31:49 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-15 00:15:13 UTC) #3
Jennifer Messerly
4 years, 11 months ago (2016-01-15 00:19:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9da8970cdf8682c672de5b50ff9c2833b6a863b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698