Issue 15853002: Handle local variable declarations without immediate assignment.

Issue 15853002: Handle local variable declarations without immediate assignment. (Closed)

Created:
7 years, 7 months ago by polux

Modified:
7 years, 7 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle local variable declarations without immediate assignment. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=23057

Patch Set 2 : Address Karl's comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -7 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1	9 chunks	+14 lines, -7 lines	0 comments	Download
	M	tests/compiler/dart2js/cpa_inference_test.dart	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://chromiumcodereview.appspot.com/15853002/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://chromiumcodereview.appspot.com/15853002/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1532 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1532: ConcreteType nil = inferrer.singletonConcreteType(const NullBaseType()); Could you make ...

7 years, 7 months ago (2013-05-23 09:41:20 UTC) #2

polux

https://chromiumcodereview.appspot.com/15853002/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://chromiumcodereview.appspot.com/15853002/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1532 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1532: ConcreteType nil = inferrer.singletonConcreteType(const NullBaseType()); On 2013/05/23 09:41:20, karlklose ...

7 years, 7 months ago (2013-05-23 10:03:57 UTC) #3

polux

7 years, 7 months ago (2013-05-23 10:05:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23057 (presubmit successful).

Expand Messages | Collapse Messages