Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1585243002: [devil] Add as_root option to DeviceUtils.PathExists. (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[devil] Add as_root option to DeviceUtils.PathExists. Android L+ apparently doesn't let a user check the contents of directories for which that user doesn't have read permissions. Go figure. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2f17b5430e275517444519278fa5dfac876b4848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M devil/devil/android/device_utils.py View 2 chunks +10 lines, -5 lines 0 comments Download
M devil/devil/android/device_utils_test.py View 1 chunk +25 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jbudorick
I'll be porting this down to chromium.
4 years, 11 months ago (2016-01-14 17:41:57 UTC) #3
rnephew (Reviews Here)
On 2016/01/14 17:41:57, jbudorick wrote: > I'll be porting this down to chromium. lgtm
4 years, 11 months ago (2016-01-14 17:50:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585243002/1
4 years, 11 months ago (2016-01-14 18:33:09 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 18:44:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698