content/renderer/render_frame_impl.cc - Issue 1585163002: Media Session: prepare for implicit activation of user created session

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1585163002: Media Session: prepare for implicit activation of user created session (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Be clearer about session being a media_session Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/html_viewer/html_frame.cc ('K') | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/modules/mediasession/HTMLMediaElementMediaSession.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index a0f8eec5486b8cb554299b7ffe02e474f0ea75a8..e4abc9b768d9bad5acd0ff88abb98dfc38ba563a 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -2378,7 +2378,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(

WebMediaPlayerClient* client,

WebMediaPlayerEncryptedMediaClient* encrypted_client,

WebContentDecryptionModule* initial_cdm,

- const blink::WebString& sink_id) {

+ const blink::WebString& sink_id,

+ WebMediaSession*) {

jochen (gone - plz use gerrit) 2016/01/25 11:34:54 please add parameter names, also for unused variab

#if defined(VIDEO_HOLE)

if (!contains_media_player_) {

render_view_->RegisterVideoHoleFrame(this);