Media Session: prepare for implicit activation of user created session

Media Session: prepare for implicit activation of user created session

Provide an optional WebMediaSession to embedder when creating a
WebMediaPlayer. A null WebMediaSession means the player should belong
to the default media session.

BUG=497735
Committed: https://crrev.com/add785e7e13f486451341b63095fb8add56d3ca1
Cr-Commit-Position: refs/heads/master@{#371530}

[davve, 2016-01-14 13:37:17]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 13:37:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585163002/1

[commit-bot: I haz the power, 2016-01-14 13:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 13:59:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davve, 2016-01-14 14:55:52]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 14:56:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585163002/20001

[davve, 2016-01-14 16:02:22]

davve@opera.com changed reviewers:
+ jochen@chromium.org, mlamouri@chromium.org, philipj@opera.com

[davve, 2016-01-14 16:02:22]

+philipj for for third_party/WebKit, +mlamouri for media session in general and
+jochen for html_viewer.

[davve, 2016-01-14 16:05:20]

For a hint for there this is going see the newly updated
https://codereview.chromium.org/1308983005/

[commit-bot: I haz the power, 2016-01-14 16:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 16:10:02]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-01-19 15:30:49]

Do you have the next patch for me to have a look? This sgtm but I wonder how you
are going to activate the WebMediaSession from content/renderer/.

[davve, 2016-01-19 15:42:53]

On 2016/01/19 15:30:49, Mounir Lamouri wrote:
> Do you have the next patch for me to have a look? This sgtm but I wonder how
you
> are going to activate the WebMediaSession from content/renderer/.

You mean something more fine-grained than
https://codereview.chromium.org/1308983005/ ?

[mlamouri (slow - plz ping), 2016-01-21 16:19:47]

I guess that CL is good enough. Though, I can see that you are using session_id
but you store a session_ in the WebMediaPlayerParams struct. It's a bit of a big
CL, could you point to the place where you get the session id? In other words,
do you actually use the session for something else than the id?

[davve, 2016-01-22 08:30:41]

On 2016/01/21 16:19:47, Mounir Lamouri wrote:
> Though, I can see that you are using session_id
> but you store a session_ in the WebMediaPlayerParams struct. It's a bit of a
big
> CL, could you point to the place where you get the session id? In other words,
> do you actually use the session for something else than the id?

Yes, the WebMediaSession is what's stored in WebMediaPlayerParams.

The session_id (an WebMediaSessionAndroid only thing) is extracted in
the constructor of WebMediaPlayerAndroid::WebMediaPlayerAndroid() and
stored as a session_id in the player. Its only planned use currently
is to be passed along to RendererMediaPlayerManager::Initialize() and
passed over IPC to the browser process.

Nit-to-self: Now, that I read WebMediaPlayerAndroid a bit closer, I
see session_id is already taken as an identifier. I should clarify our
session by prefixing it with media_.

[philipj_slow, 2016-01-25 11:28:52]

This LGTM. Doesn't do much yet, of course :)

[jochen (gone - plz use gerrit), 2016-01-25 11:34:55]

lgtm with comment

https://codereview.chromium.org/1585163002/diff/40001/components/html_viewer/...
File components/html_viewer/html_frame.cc (right):

https://codereview.chromium.org/1585163002/diff/40001/components/html_viewer/...
components/html_viewer/html_frame.cc:319: blink::WebMediaSession*) {
same here

https://codereview.chromium.org/1585163002/diff/40001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1585163002/diff/40001/content/renderer/render...
content/renderer/render_frame_impl.cc:2382: WebMediaSession*) {
please add parameter names, also for unused variables

[davve, 2016-01-26 12:29:29]

The CQ bit was checked by davve@opera.com

[davve, 2016-01-26 12:29:30]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1585163002/#ps100001
(title: "Add parameter names, also for unused variables")

[commit-bot: I haz the power, 2016-01-26 12:29:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585163002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585163002/100001

[commit-bot: I haz the power, 2016-01-26 15:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 15:25:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[davve, 2016-01-26 16:29:25]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-01-26 16:29:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585163002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585163002/100001

[mlamouri (slow - plz ping), 2016-01-26 16:52:14]

lgtm

[commit-bot: I haz the power, 2016-01-26 17:40:46]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-01-26 17:42:18]

Description was changed from

==========
Media Session: prepare for implicit activation of user created session

Provide an optional WebMediaSession to embedder when creating a
WebMediaPlayer. A null WebMediaSession means the player should belong
to the default media session.

BUG=497735
==========

to

==========
Media Session: prepare for implicit activation of user created session

Provide an optional WebMediaSession to embedder when creating a
WebMediaPlayer. A null WebMediaSession means the player should belong
to the default media session.

BUG=497735

Committed: https://crrev.com/add785e7e13f486451341b63095fb8add56d3ca1
Cr-Commit-Position: refs/heads/master@{#371530}
==========

[commit-bot: I haz the power, 2016-01-26 17:42:19]

Patchset 5 (id:??) landed as
https://crrev.com/add785e7e13f486451341b63095fb8add56d3ca1
Cr-Commit-Position: refs/heads/master@{#371530}