Chromium Code Reviews

Issue 158513002: Fix WorkerGlobalScopePerformance thread state mismatch asserts. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
haraken, Mads Ager (chromium)
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix WorkerGlobalScopePerformance thread state mismatch asserts. A handful of worker tests (in webexposed/ and http/tests/w3c/webperf/) currently assert and fail. The Persistent reference to WorkerPerformance from WorkerGlobalScopePerformance requires that the worker thread looks up and uses the current thread state rather than that of the main thread. That state is associated with the Persistent object when created. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166791

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5 lines, -2 lines)
M Source/modules/performance/WorkerGlobalScopePerformance.h View 1 chunk +1 line, -2 lines 0 comments
M Source/modules/performance/WorkerPerformance.h View 2 chunks +4 lines, -0 lines 0 comments

Messages

Total messages: 10 (0 generated)
sof
Please take a look. Have been running into these asserts since https://codereview.chromium.org/157213002 landed, but couldn't ...
6 years, 10 months ago (2014-02-09 20:31:48 UTC) #1
haraken
LGTM. Thank you very much for making this fix. I have to double-check whether other ...
6 years, 10 months ago (2014-02-10 00:55:59 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-10 00:56:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/158513002/1
6 years, 10 months ago (2014-02-10 00:56:07 UTC) #4
commit-bot: I haz the power
Change committed as 166791
6 years, 10 months ago (2014-02-10 03:17:44 UTC) #5
zerny-chromium
On 2014/02/10 00:55:59, haraken wrote: > LGTM. > > Thank you very much for making ...
6 years, 10 months ago (2014-02-11 06:34:23 UTC) #6
haraken
On 2014/02/11 06:34:23, zerny-chromium wrote: > On 2014/02/10 00:55:59, haraken wrote: > > LGTM. > ...
6 years, 10 months ago (2014-02-11 07:01:21 UTC) #7
zerny-chromium
On 2014/02/11 07:01:21, haraken wrote: > On 2014/02/11 06:34:23, zerny-chromium wrote: > > On 2014/02/10 ...
6 years, 10 months ago (2014-02-11 07:20:09 UTC) #8
haraken
> > I was also thinking about where to put the macro. (We have a ...
6 years, 10 months ago (2014-02-11 07:34:57 UTC) #9
haraken
6 years, 10 months ago (2014-02-11 08:05:23 UTC) #10
Message was sent while issue was closed.
> > If you don't think the includes will cause trouble then I'm OK with them,
but
> > lets bring up the issue at our next oilpan sync.
> 
> Sure :)

I'm on vacation today and unfortunately my home network isn't working well, so I
cannot attend the sync-up today :(

Either way, at the moment I'll move the macros to ThreadState.h in a follow-up
tomorrow. keishi-san is now evaluating whether the threading affinity really
matters or not, so we can get back to this issue after seeing the result.

Powered by Google App Engine