Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1585113007: win: Call clang-cl instead of clang-cl.exe when targeting win on a non-win host. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Call clang-cl instead of clang-cl.exe when targeting win on a non-win host. No behavior change, since non-win hosts targeting windows currently don't exist. But if they did, there are three choices for how to invoke the compiler: 1. Call the compiler on the host clang-cl.exe instead of clang-cl. That's weird because clang-cl is a host-native binary. 2. Don't append ".exe" to any program in build/toolchain/win/BUILD.gn -- it's probably not needed on Windows. But if we end up running real Windows binaries on non-Windows (e.g. midl.exe through wine), then those would have a .exe extension on the non-Windows host. 3. Do what this CL does. This seems nicest. BUG=495204 Committed: https://crrev.com/8391051c80fa58d3b4a9021f4185cbc71e69f32e Cr-Commit-Position: refs/heads/master@{#369854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/toolchain/win/BUILD.gn View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
((The motivation here is upstreaming easy changes from my build-chrome-win-on-mac branch)
4 years, 11 months ago (2016-01-15 01:00:04 UTC) #2
brettw
lgtm
4 years, 11 months ago (2016-01-15 21:19:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585113007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585113007/1
4 years, 11 months ago (2016-01-15 21:23:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 21:52:14 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 21:53:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8391051c80fa58d3b4a9021f4185cbc71e69f32e
Cr-Commit-Position: refs/heads/master@{#369854}

Powered by Google App Engine
This is Rietveld 408576698