Issue 1585103006: - Add support for passing data: based URIs as packageConfig to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1585103006: - Add support for passing data: based URIs as packageConfig to (Closed)

Created:
4 years, 11 months ago by Ivan Posva

Modified:
4 years, 11 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Add support for passing data: based URIs as packageConfig to Isolate.spawnUri. - Loosen the expected mimeType and encoding for data: URI based file loading. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4f54e6aee5027c4303591842dcae6b0f5d2eb4f9

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -14 lines)			Patch
M	runtime/bin/vmservice/loader.dart	View	4 chunks	+31 lines, -5 lines	0 comments	Download
M	runtime/tests/vm/vm.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download
A +	tests/isolate/scenarios/package_data_uri_spec/package_resolve_test.dart	View	1 chunk	+10 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Ivan Posva

4 years, 11 months ago (2016-01-16 01:02:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4f54e6aee5027c4303591842dcae6b0f5d2eb4f9 (presubmit successful).