Move synchronous compositor into content/browser

content/renderer/android/synchronous_compositor_factory.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_ANDROID_SYNCHRONOUS_COMPOSITOR_FACTORY_H_
+#define CONTENT_RENDERER_ANDROID_SYNCHRONOUS_COMPOSITOR_FACTORY_H_
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+
+namespace base {
+class MessageLoopProxy;
+}
+
+namespace cc {
+class OutputSurface;
+}
+
+namespace content {
+
+// Decouples creation from usage of the parts needed for the synchonous
+// compositor rendering path. In practice this is only used in single
+// process mode (namely, for Android WebView) hence the implementation of
+// this will be injected from the logical 'browser' side code.
+class SynchronousCompositorFactory {
+ public:
+  // Must only be called once, e.g. on startup. Ownership of |instance| remains
+  // with the caller.
+  static void SetInstance(SynchronousCompositorFactory* instance);
+  static SynchronousCompositorFactory* GetInstance();
+  static bool HasInstance() { return GetInstance() != NULL; }

[jamesr, 2013/05/30 20:28:57]

nit: i don't find this terribly valuable, code could just as easily do

if (GetInstance()) { .... }

or perhaps more usefully

if (SynchronousCompositorFactory* factory = ...GetInstance() {
  factory->Blahblahblah()
}

[joth, 2013/05/30 21:22:14]

Done.
In my mind I was thinking of something a little more abstracted here like
"IsEnabled()" but I agree it's basically redundant and I like your second
suggestion so going with that (where applicable)

+
+  virtual scoped_refptr<base::MessageLoopProxy>
+      GetCompositorMessageLoop() = 0;
+  virtual scoped_ptr<cc::OutputSurface> CreateOutputSurface(
+      int routing_id) = 0;
+
+ protected:
+  SynchronousCompositorFactory() {}
+  ~SynchronousCompositorFactory() {}
+};
+
+}
+
+#endif  // CONTENT_RENDERER_ANDROID_SYNCHRONOUS_COMPOSITOR_FACTORY_H_