Chain SummaryResynthesizer(s).

Chain SummaryResynthesizer(s).

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/ca5bf28fa53cd7651b1dfd5bc779eedd06e8099b

[Paul Berry, 2016-01-14 18:54:39]

lgtm

https://codereview.chromium.org/1585093003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1585093003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:112: String libraryUri =
components[0];
Personally I would move this up to line 110, and delete lines 119 and 122.  It's
clearer, and the only behavioral difference is that it changes the type of
exception that would be thrown in the case where location.components is the
empty list (which should never happen anyway).

Your call, though.

[scheglov, 2016-01-14 22:43:08]

https://codereview.chromium.org/1585093003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1585093003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:112: String libraryUri =
components[0];
On 2016/01/14 18:54:39, Paul Berry wrote:
> Personally I would move this up to line 110, and delete lines 119 and 122. 
It's
> clearer, and the only behavioral difference is that it changes the type of
> exception that would be thrown in the case where location.components is the
> empty list (which should never happen anyway).
> 
> Your call, though.

Done.

[scheglov, 2016-01-14 22:43:33]

Description was changed from

==========
Chain SummaryResynthesizer(s).

R=paulberry@google.com
BUG=
==========

to

==========
Chain SummaryResynthesizer(s).

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/ca5bf28fa53cd7651b1dfd5bc779eedd06e8099b
==========

[scheglov, 2016-01-14 22:43:34]

Committed patchset #1 (id:1) manually as
ca5bf28fa53cd7651b1dfd5bc779eedd06e8099b (presubmit successful).