Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1585093002: [test] Clean up valgrind runner. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Clean up valgrind runner. - Use valgrind from v8/third_party/valgrind fetched as custom deps. This will make the check more portable on buildbot slaves without the need to install valgrind. - Build path to checked executable to be ready for swarming. BUG=chromium:535160 LOG=n NOTRY=true Committed: https://crrev.com/6413507c3845afdcf4d92affaef2a5ea44b67665 Cr-Commit-Position: refs/heads/master@{#33287}

Patch Set 1 #

Patch Set 2 : Skip reachability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M tools/run-valgrind.py View 1 2 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL. I was about to delete the bot, but now that it found something again ...
4 years, 11 months ago (2016-01-14 10:24:05 UTC) #3
Jakob Kummerow
lgtm
4 years, 11 months ago (2016-01-14 10:37:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585093002/20001
4 years, 11 months ago (2016-01-14 10:38:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 10:41:53 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 10:42:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6413507c3845afdcf4d92affaef2a5ea44b67665
Cr-Commit-Position: refs/heads/master@{#33287}

Powered by Google App Engine
This is Rietveld 408576698