Issue 1585073004: dart2js cps: Remove default call to visit return continuation.

Issue 1585073004: dart2js cps: Remove default call to visit return continuation. (Closed)

Created:
4 years, 11 months ago by asgerf

Modified:
4 years, 11 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Remove default call to visit return continuation. There seems to be no use case for visiting the return continuation automatically, and it's often causing problems. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/8226a28185f5048d4ca12b5e5737e9f17ce0e07f

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (3 generated)

Kevin Millikin (Google)

Thanks. That's bothered me before too. LGTM.

4 years, 11 months ago (2016-01-15 12:28:47 UTC) #4

asgerf

4 years, 11 months ago (2016-01-15 17:26:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8226a28185f5048d4ca12b5e5737e9f17ce0e07f (presubmit successful).