chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java - Issue 1584993002: Delete code involving overdraw bottom height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java

Issue 1584993002: Delete code involving overdraw bottom height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete more mCachedVisibleViewport lines Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockLayoutHost.java ('k') | chrome/browser/android/compositor/compositor_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java

index 22663f6e880882450891e0707836c83167ca310e..d90f1689f3ef6b798b66b6dd7c6ab2bb9c1abd54 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java

@@ -532,12 +532,11 @@ public abstract class CastTestBase extends ChromeActivityTestCaseBase<ChromeActi

ContentViewCore core = tab.getContentViewCore();

int clickX =

(int) core.getRenderCoordinates().fromLocalCssToPix(

- ((float) (rect.left + rect.right)) / 2)

- + core.getViewportSizeOffsetWidthPix();

+ ((float) (rect.left + rect.right)) / 2);

int clickY =

(int) core.getRenderCoordinates().fromLocalCssToPix(

((float) (rect.top + rect.bottom)) / 2)

- + core.getViewportSizeOffsetHeightPix();

+ + core.getTopControlsHeightPix();

// Click using a virtual mouse, since a touch may result in a disambiguation pop-up.

mouseSingleClickView(getInstrumentation(), tab.getView(), clickX, clickY);

}