Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1584923002: Subzero: Fix -build-atts option. (Closed)

Created:
4 years, 11 months ago by Jim Stichnoth
Modified:
4 years, 11 months ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix -build-atts option. If the default --target option is not actually included in the Subzero build (via llvm/Config/SZTargets.def), then "pnacl-sz --build-atts" will fail. This is because the attribute printing is done after the GlobalContext is created, which does some amount of Target initialization. The fix is to move the attribute printing to a point after the flags are parsed and the output streams are created, but before the GlobalContext is created. This basically disables --build-atts in the browser build, but that should be OK. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=686f35e569f7fac14d357550faed542de261415b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M src/IceCompileServer.cpp View 2 chunks +29 lines, -0 lines 0 comments Download
M src/IceCompiler.cpp View 3 chunks +2 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 11 months ago (2016-01-13 21:11:07 UTC) #3
Karl
lgtm
4 years, 11 months ago (2016-01-13 21:14:01 UTC) #4
Jim Stichnoth
4 years, 11 months ago (2016-01-13 21:48:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
686f35e569f7fac14d357550faed542de261415b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698