Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1584913003: [turbofan] Restore i32+i32->i32 handling in representation inference. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Restore i32+i32->i32 handling in representation inference. This restores the case that was removed by commit f0e41175fde3d86f3790d69dfa6c9cb0a01eaad2 Author: jarin <jarin@chromium.org>; Date: Tue Jan 5 03:56:04 2016 -0800 [turbofan] Bidirectional representation inference. BUG=v8:4667 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/59ff83f6b0096dfd6572dd24c6b165ff6a58d328 Cr-Commit-Position: refs/heads/master@{#33292}

Patch Set 1 #

Patch Set 2 : Comment tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
4 years, 11 months ago (2016-01-14 08:43:30 UTC) #1
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-14 11:19:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584913003/20001
4 years, 11 months ago (2016-01-14 11:44:53 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 11:49:22 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 11:50:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59ff83f6b0096dfd6572dd24c6b165ff6a58d328
Cr-Commit-Position: refs/heads/master@{#33292}

Powered by Google App Engine
This is Rietveld 408576698